Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: src/ic/arm64/ic-arm64.cc

Issue 1909433003: Remove support for Object.observe (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebased Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/arm/ic-arm.cc ('k') | src/ic/ia32/ic-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/ic-compiler.h" 9 #include "src/ic/ic-compiler.h"
10 #include "src/ic/stub-cache.h" 10 #include "src/ic/stub-cache.h"
(...skipping 604 matching lines...) Expand 10 before | Expand all | Expand 10 after
615 DCHECK(value.is(x0)); 615 DCHECK(value.is(x0));
616 616
617 Register receiver_map = x3; 617 Register receiver_map = x3;
618 Register elements = x4; 618 Register elements = x4;
619 Register elements_map = x5; 619 Register elements_map = x5;
620 620
621 __ JumpIfNotSmi(key, &maybe_name_key); 621 __ JumpIfNotSmi(key, &maybe_name_key);
622 __ JumpIfSmi(receiver, &slow); 622 __ JumpIfSmi(receiver, &slow);
623 __ Ldr(receiver_map, FieldMemOperand(receiver, HeapObject::kMapOffset)); 623 __ Ldr(receiver_map, FieldMemOperand(receiver, HeapObject::kMapOffset));
624 624
625 // Check that the receiver does not require access checks and is not observed. 625 // Check that the receiver does not require access checks.
626 // The generic stub does not perform map checks or handle observed objects. 626 // The generic stub does not perform map checks.
627 __ Ldrb(x10, FieldMemOperand(receiver_map, Map::kBitFieldOffset)); 627 __ Ldrb(x10, FieldMemOperand(receiver_map, Map::kBitFieldOffset));
628 __ TestAndBranchIfAnySet( 628 __ TestAndBranchIfAnySet(x10, (1 << Map::kIsAccessCheckNeeded), &slow);
629 x10, (1 << Map::kIsAccessCheckNeeded) | (1 << Map::kIsObserved), &slow);
630 629
631 // Check if the object is a JS array or not. 630 // Check if the object is a JS array or not.
632 Register instance_type = x10; 631 Register instance_type = x10;
633 __ CompareInstanceType(receiver_map, instance_type, JS_ARRAY_TYPE); 632 __ CompareInstanceType(receiver_map, instance_type, JS_ARRAY_TYPE);
634 __ B(eq, &array); 633 __ B(eq, &array);
635 // Check that the object is some kind of JS object EXCEPT JS Value type. In 634 // Check that the object is some kind of JS object EXCEPT JS Value type. In
636 // the case that the object is a value-wrapper object, we enter the runtime 635 // the case that the object is a value-wrapper object, we enter the runtime
637 // system to make sure that indexing into string objects works as intended. 636 // system to make sure that indexing into string objects works as intended.
638 STATIC_ASSERT(JS_VALUE_TYPE < JS_OBJECT_TYPE); 637 STATIC_ASSERT(JS_VALUE_TYPE < JS_OBJECT_TYPE);
639 __ Cmp(instance_type, JS_OBJECT_TYPE); 638 __ Cmp(instance_type, JS_OBJECT_TYPE);
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
858 } else { 857 } else {
859 DCHECK(to_patch->Mask(TestBranchMask) == TBNZ); 858 DCHECK(to_patch->Mask(TestBranchMask) == TBNZ);
860 // This is JumpIfSmi(smi_reg, branch_imm). 859 // This is JumpIfSmi(smi_reg, branch_imm).
861 patcher.tbz(smi_reg, 0, branch_imm); 860 patcher.tbz(smi_reg, 0, branch_imm);
862 } 861 }
863 } 862 }
864 } // namespace internal 863 } // namespace internal
865 } // namespace v8 864 } // namespace v8
866 865
867 #endif // V8_TARGET_ARCH_ARM64 866 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/ic/arm/ic-arm.cc ('k') | src/ic/ia32/ic-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698