Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: src/ic/arm/ic-arm.cc

Issue 1909433003: Remove support for Object.observe (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebased Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/heap.cc ('k') | src/ic/arm64/ic-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/ic-compiler.h" 9 #include "src/ic/ic-compiler.h"
10 #include "src/ic/stub-cache.h" 10 #include "src/ic/stub-cache.h"
(...skipping 608 matching lines...) Expand 10 before | Expand all | Expand 10 after
619 Register elements_map = r6; 619 Register elements_map = r6;
620 Register elements = r9; // Elements array of the receiver. 620 Register elements = r9; // Elements array of the receiver.
621 // r4 and r5 are used as general scratch registers. 621 // r4 and r5 are used as general scratch registers.
622 622
623 // Check that the key is a smi. 623 // Check that the key is a smi.
624 __ JumpIfNotSmi(key, &maybe_name_key); 624 __ JumpIfNotSmi(key, &maybe_name_key);
625 // Check that the object isn't a smi. 625 // Check that the object isn't a smi.
626 __ JumpIfSmi(receiver, &slow); 626 __ JumpIfSmi(receiver, &slow);
627 // Get the map of the object. 627 // Get the map of the object.
628 __ ldr(receiver_map, FieldMemOperand(receiver, HeapObject::kMapOffset)); 628 __ ldr(receiver_map, FieldMemOperand(receiver, HeapObject::kMapOffset));
629 // Check that the receiver does not require access checks and is not observed. 629 // Check that the receiver does not require access checks.
630 // The generic stub does not perform map checks or handle observed objects. 630 // The generic stub does not perform map checks.
631 __ ldrb(ip, FieldMemOperand(receiver_map, Map::kBitFieldOffset)); 631 __ ldrb(ip, FieldMemOperand(receiver_map, Map::kBitFieldOffset));
632 __ tst(ip, Operand(1 << Map::kIsAccessCheckNeeded | 1 << Map::kIsObserved)); 632 __ tst(ip, Operand(1 << Map::kIsAccessCheckNeeded));
633 __ b(ne, &slow); 633 __ b(ne, &slow);
634 // Check if the object is a JS array or not. 634 // Check if the object is a JS array or not.
635 __ ldrb(r4, FieldMemOperand(receiver_map, Map::kInstanceTypeOffset)); 635 __ ldrb(r4, FieldMemOperand(receiver_map, Map::kInstanceTypeOffset));
636 __ cmp(r4, Operand(JS_ARRAY_TYPE)); 636 __ cmp(r4, Operand(JS_ARRAY_TYPE));
637 __ b(eq, &array); 637 __ b(eq, &array);
638 // Check that the object is some kind of JS object EXCEPT JS Value type. In 638 // Check that the object is some kind of JS object EXCEPT JS Value type. In
639 // the case that the object is a value-wrapper object, we enter the runtime 639 // the case that the object is a value-wrapper object, we enter the runtime
640 // system to make sure that indexing into string objects works as intended. 640 // system to make sure that indexing into string objects works as intended.
641 STATIC_ASSERT(JS_VALUE_TYPE < JS_OBJECT_TYPE); 641 STATIC_ASSERT(JS_VALUE_TYPE < JS_OBJECT_TYPE);
642 __ cmp(r4, Operand(JS_OBJECT_TYPE)); 642 __ cmp(r4, Operand(JS_OBJECT_TYPE));
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
879 patcher.EmitCondition(ne); 879 patcher.EmitCondition(ne);
880 } else { 880 } else {
881 DCHECK(Assembler::GetCondition(branch_instr) == ne); 881 DCHECK(Assembler::GetCondition(branch_instr) == ne);
882 patcher.EmitCondition(eq); 882 patcher.EmitCondition(eq);
883 } 883 }
884 } 884 }
885 } // namespace internal 885 } // namespace internal
886 } // namespace v8 886 } // namespace v8
887 887
888 #endif // V8_TARGET_ARCH_ARM 888 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/heap/heap.cc ('k') | src/ic/arm64/ic-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698