Only use the LoggingLock when actually logging to a file

Only use the LoggingLock when actually logging to a file

Also coalesce some duplicated log-file-closing code.

BUG=257196
R=alexeypa@chromium.org, darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211709

[akalin, 2013-07-12 08:16:22]

+darin for base/
+alexeypa for remoting/

[akalin, 2013-07-12 19:38:33]

Oops, forgot brettw@ is the one that reviews logging.{h,cc}. -darin, +brettw for
review.

[alexeypa (please no reviews), 2013-07-15 15:59:53]

remoting/* - lgtm

[darin (slow to review), 2013-07-15 18:35:37]

LGTM

https://codereview.chromium.org/19091004/diff/1/base/logging.cc
File base/logging.cc (right):

https://codereview.chromium.org/19091004/diff/1/base/logging.cc#newcode393
base/logging.cc:393: // calling InitLogging twice or after some log call has
already opened the
nit: Use sentence formatting.

[akalin, 2013-07-15 19:06:21]

https://codereview.chromium.org/19091004/diff/1/base/logging.cc
File base/logging.cc (right):

https://codereview.chromium.org/19091004/diff/1/base/logging.cc#newcode393
base/logging.cc:393: // calling InitLogging twice or after some log call has
already opened the
On 2013/07/15 18:35:37, darin wrote:
> nit: Use sentence formatting.

Done.

[commit-bot: I haz the power, 2013-07-15 19:06:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/19091004/11001

[commit-bot: I haz the power, 2013-07-15 19:18:04]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2013-07-15 19:30:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/19091004/11001

[akalin, 2013-07-15 21:47:35]

Committed patchset #2 manually as r211709 (presubmit successful).