Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: remoting/host/logging_win.cc

Issue 19091004: Only use the LoggingLock when actually logging to a file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/logging_posix.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/logging_win.cc
diff --git a/remoting/host/logging_win.cc b/remoting/host/logging_win.cc
index b874113a414a609d763ac51b13e691d0fb8bf829..be69773eecc7e1af836b0b6c7df0dc2d660aacd4 100644
--- a/remoting/host/logging_win.cc
+++ b/remoting/host/logging_win.cc
@@ -20,9 +20,6 @@ void InitHostLogging() {
// Write logs to the system debug log.
logging::LoggingSettings settings;
settings.logging_dest = logging::LOG_TO_SYSTEM_DEBUG_LOG;
- // TODO(alexeypa): remove this line once logging is updated to not create
- // the lock if the log file is not used.
- settings.lock_log = logging::DONT_LOCK_LOG_FILE;
logging::InitLogging(settings);
// Enable trace control and transport through event tracing for Windows.
« no previous file with comments | « remoting/host/logging_posix.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698