remoting/host/logging_posix.cc - Issue 19091004: Only use the LoggingLock when actually logging to a file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/logging_posix.cc

Issue 19091004: Only use the LoggingLock when actually logging to a file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/host/logging_posix.cc

diff --git a/remoting/host/logging_posix.cc b/remoting/host/logging_posix.cc

index 1d7773ac5c090f17e39cdc69d12f9abd14d42eed..d29086ecb46b353c45c9dd36cd7a274dcad51845 100644

--- a/remoting/host/logging_posix.cc

+++ b/remoting/host/logging_posix.cc

@@ -12,9 +12,6 @@ void InitHostLogging() {

// Write logs to the system debug log.

logging::LoggingSettings settings;

settings.logging_dest = logging::LOG_TO_SYSTEM_DEBUG_LOG;

- // TODO(alexeypa): remove this line once logging is updated to not create

- // the lock if the log file is not used.

- settings.lock_log = logging::DONT_LOCK_LOG_FILE;

logging::InitLogging(settings);

}

« no previous file with comments | « base/logging.cc ('k') | remoting/host/logging_win.cc » ('j') | no next file with comments »