Code completion improvement, use type information when suggesting constructors, part 2.

Code completion improvement, use type information when suggesting constructors, part 2.

This finishes the work started with https://codereview.chromium.org/1892823003/, by also adding the filter into the local_library_contributor.dart.

BUG=https://github.com/dart-lang/sdk/issues/26254
R=danrubel@google.com

Committed: https://github.com/dart-lang/sdk/commit/cc065a3ad098d4811e12d8567c06ce38dc740da6

[jwren, 2016-04-20 21:55:48]

jwren@google.com changed reviewers:
+ danrubel@google.com

[danrubel, 2016-04-21 12:56:09]

LGTM

https://codereview.chromium.org/1908703002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart
(right):

https://codereview.chromium.org/1908703002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart:56:
int filter = optype.constructorSuggestionsFilter(element.type);
Should we pass in relevance, return relevance, and add the suggestion only if
returned relevance != null? Would that help cut down on the boilerplate code?

https://codereview.chromium.org/1908703002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart:183:
// then resolve the outermost/entire expression
Move comment down to just above the "resolveContainingExpression" statement?

[jwren, 2016-04-21 17:15:43]

https://codereview.chromium.org/1908703002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart
(right):

https://codereview.chromium.org/1908703002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart:56:
int filter = optype.constructorSuggestionsFilter(element.type);
On 2016/04/21 12:56:09, danrubel wrote:
> Should we pass in relevance, return relevance, and add the suggestion only if
> returned relevance != null? Would that help cut down on the boilerplate code?

Like this, right:

int relevance = optype.constructorSuggestionsFilter(element.type,
DART_RELEVANCE_DEFAULT);
if(relevance != null) {
  addConstructorSuggestions(element, relevance);
}

I will follow up with another CL, I want have all such filters that return an
int to work the same way, and I believe that there is another one.

https://codereview.chromium.org/1908703002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart:183:
// then resolve the outermost/entire expression
On 2016/04/21 12:56:09, danrubel wrote:
> Move comment down to just above the "resolveContainingExpression" statement?

Done.

[jwren, 2016-04-21 17:16:10]

Description was changed from

==========
Code completion improvement, use type information when suggesting constructors,
part 2.

This finishes the work started with https://codereview.chromium.org/1892823003/,
by also adding the filter into the local_library_contributor.dart.

BUG=https://github.com/dart-lang/sdk/issues/26254
==========

to

==========
Code completion improvement, use type information when suggesting constructors,
part 2.

This finishes the work started with https://codereview.chromium.org/1892823003/,
by also adding the filter into the local_library_contributor.dart.

BUG=https://github.com/dart-lang/sdk/issues/26254
R=danrubel@google.com

Committed:
https://github.com/dart-lang/sdk/commit/cc065a3ad098d4811e12d8567c06ce38dc740da6
==========

[jwren, 2016-04-21 17:16:11]

Committed patchset #2 (id:20001) manually as
cc065a3ad098d4811e12d8567c06ce38dc740da6 (presubmit successful).

[danrubel, 2016-04-21 17:18:54]

https://codereview.chromium.org/1908703002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart
(right):

https://codereview.chromium.org/1908703002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart:56:
int filter = optype.constructorSuggestionsFilter(element.type);
On 2016/04/21 17:15:43, jwren wrote:
> On 2016/04/21 12:56:09, danrubel wrote:
> > Should we pass in relevance, return relevance, and add the suggestion only
if
> > returned relevance != null? Would that help cut down on the boilerplate
code?
> 
> Like this, right:
> 
> int relevance = optype.constructorSuggestionsFilter(element.type,
> DART_RELEVANCE_DEFAULT);
> if(relevance != null) {
>   addConstructorSuggestions(element, relevance);
> }
> 
> I will follow up with another CL, I want have all such filters that return an
> int to work the same way, and I believe that there is another one.

Yes.