Code completion improvement, use type information when suggesting constructors

Code completion improvement, use type information when suggesting constructors

BUG=https://github.com/dart-lang/sdk/issues/26254
R=danrubel@google.com

Committed: https://github.com/dart-lang/sdk/commit/214a201ae57ebd4a0692eb9f2249089aff253a31

[jwren, 2016-04-15 22:31:44]

jwren@google.com changed reviewers:
+ danrubel@google.com

[danrubel, 2016-04-17 13:02:13]

LGTM

https://codereview.chromium.org/1892823003/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart
(right):

https://codereview.chromium.org/1892823003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart:168:
_Visitor visitor = new _Visitor(request, suggestions, optype);
Please move this line down to just before the call to "visit" to prevent target
information from being inadvertently cached in the class.

https://codereview.chromium.org/1892823003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart:178:
await request.resolveExpression(node);
You must discard any cached target information after resolution because it may
have changed. See
https://github.com/dart-lang/sdk/blob/master/pkg/analysis_server/lib/src/serv...

[jwren, 2016-04-18 19:11:26]

https://codereview.chromium.org/1892823003/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart
(right):

https://codereview.chromium.org/1892823003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart:168:
_Visitor visitor = new _Visitor(request, suggestions, optype);
On 2016/04/17 13:02:13, danrubel wrote:
> Please move this line down to just before the call to "visit" to prevent
target
> information from being inadvertently cached in the class.

Done.

https://codereview.chromium.org/1892823003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart:178:
await request.resolveExpression(node);
On 2016/04/17 13:02:13, danrubel wrote:
> You must discard any cached target information after resolution because it may
> have changed. See
>
https://github.com/dart-lang/sdk/blob/master/pkg/analysis_server/lib/src/serv...

Done.

[jwren, 2016-04-18 19:11:49]

Description was changed from

==========
Code completion improvement, use type information when suggesting constructors

BUG=https://github.com/dart-lang/sdk/issues/26254
==========

to

==========
Code completion improvement, use type information when suggesting constructors

BUG=https://github.com/dart-lang/sdk/issues/26254
R=danrubel@google.com

Committed:
https://github.com/dart-lang/sdk/commit/214a201ae57ebd4a0692eb9f2249089aff253a31
==========

[jwren, 2016-04-18 19:11:50]

Committed patchset #3 (id:40001) manually as
214a201ae57ebd4a0692eb9f2249089aff253a31 (presubmit successful).