Remove special case svn to git translations for FFmpeg.

Remove special case svn to git translations for FFmpeg.

This reverts the relevant pieces of https://codereview.chromium.org/9359045/

I'll update Chrome's DEPS file to use the new syntax and roll
deps2git at the same time in a followup CL.

BUG=329002
TEST=deps2git outputs correct DEPS.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=270695

[DaleCurtis, 2014-03-07 21:46:14]

Followup DEPS roll CL is here: https://codereview.chromium.org/191553002/

[szager1, 2014-03-07 22:43:53]

https://codereview.chromium.org/190853003/diff/40001/deps2git.py
File deps2git.py (right):

https://codereview.chromium.org/190853003/diff/40001/deps2git.py#newcode250
deps2git.py:250: deps, baddeps = ConvertDepsToGit(deps, options, deps_vars)
There might be other uses of svn_deps_vars besides ffmpeg, no?

[DaleCurtis, 2014-03-07 22:50:50]

https://codereview.chromium.org/190853003/diff/40001/deps2git.py
File deps2git.py (right):

https://codereview.chromium.org/190853003/diff/40001/deps2git.py#newcode250
deps2git.py:250: deps, baddeps = ConvertDepsToGit(deps, options, deps_vars)
On 2014/03/07 22:43:53, szager1 wrote:
> There might be other uses of svn_deps_vars besides ffmpeg, no?

None exist at this time AFAICT so it seems better to remove.  Is there any other
place these users could reside?

[szager1, 2014-03-07 23:04:52]

Adding mmoss for review, as this may affect buildspec conversion.

https://codereview.chromium.org/190853003/diff/40001/deps2git.py
File deps2git.py (right):

https://codereview.chromium.org/190853003/diff/40001/deps2git.py#newcode82
deps2git.py:82: if options.extra_rules:
This is where extra svn_to_git_*.py modules are pulled in.

https://codereview.chromium.org/190853003/diff/40001/deps2git.py#newcode250
deps2git.py:250: deps, baddeps = ConvertDepsToGit(deps, options, deps_vars)
On 2014/03/07 22:50:51, DaleCurtis wrote:
> On 2014/03/07 22:43:53, szager1 wrote:
> > There might be other uses of svn_deps_vars besides ffmpeg, no?
> 
> None exist at this time AFAICT so it seems better to remove.  Is there any
other
> place these users could reside?

Yes, there are svn_to_git_*.py modules for internal code that may use
deps_overrides and svn_deps_vars.

[mmoss, 2014-03-07 23:27:18]

It doesn't seem like this is going to be a problem for internal, but then again,
it's probably fine to leave the overrides functionality in and just take out the
ffmpeg entries from svn_to_git_public.py, if you want to keep the change simple.

https://codereview.chromium.org/190853003/diff/40001/deps2git.py
File deps2git.py (right):

https://codereview.chromium.org/190853003/diff/40001/deps2git.py#newcode250
deps2git.py:250: deps, baddeps = ConvertDepsToGit(deps, options, deps_vars)
On 2014/03/07 23:04:53, szager1 wrote:
> On 2014/03/07 22:50:51, DaleCurtis wrote:
> > On 2014/03/07 22:43:53, szager1 wrote:
> > > There might be other uses of svn_deps_vars besides ffmpeg, no?
> > 
> > None exist at this time AFAICT so it seems better to remove.  Is there any
> other
> > place these users could reside?
> 
> Yes, there are svn_to_git_*.py modules for internal code that may use
> deps_overrides and svn_deps_vars.

The only one I'm aware of doesn't have and DEPS_OVERRIDES.

[DaleCurtis, 2014-03-07 23:30:26]

Since I added this mess, I'd prefer to delete it if no one is using it, but
defer to your judgement.

https://codereview.chromium.org/190853003/diff/40001/deps2git.py
File deps2git.py (right):

https://codereview.chromium.org/190853003/diff/40001/deps2git.py#newcode250
deps2git.py:250: deps, baddeps = ConvertDepsToGit(deps, options, deps_vars)
On 2014/03/07 23:27:18, mmoss wrote:
> On 2014/03/07 23:04:53, szager1 wrote:
> > On 2014/03/07 22:50:51, DaleCurtis wrote:
> > > On 2014/03/07 22:43:53, szager1 wrote:
> > > > There might be other uses of svn_deps_vars besides ffmpeg, no?
> > > 
> > > None exist at this time AFAICT so it seems better to remove.  Is there any
> > other
> > > place these users could reside?
> > 
> > Yes, there are svn_to_git_*.py modules for internal code that may use
> > deps_overrides and svn_deps_vars.
> 
> The only one I'm aware of doesn't have and DEPS_OVERRIDES.

Yeah, I checked that one and didn't see any.

[szager1, 2014-03-11 23:53:06]

lgtm

[DaleCurtis, 2014-03-12 00:14:27]

kbr points out he's about to use this code, so I defer to the Infra team for his
use case.  I'm going to change this CL just to remove the usage by FFmpeg.

[DaleCurtis, 2014-03-12 00:52:33]

Per email, szager prefers to remove this code.  I'm heading out on the Chrome
offsite tomorrow and borenet@ still hasn't landed the gclient cleanup changes,
so I'm going to hold this until next Monday (by which time borenet@'s change
will hopefully have landed).

[DaleCurtis, 2014-03-20 18:07:20]

Still pending https://codereview.chromium.org/195913002/ which should hopefully
land soon.

[DaleCurtis, 2014-05-14 00:07:14]

PTAL.  Significantly rebased since the original review.

[szager1, 2014-05-15 07:23:36]

Still lgtm.

If you land this quickly, you won't have to rebase it against:

https://codereview.chromium.org/281183003/

... which would probably be painful.

[DaleCurtis, 2014-05-15 16:47:16]

Thanks. mmoss: Any comments?

[Michael Moss, 2014-05-15 16:51:47]

On 2014/05/15 16:47:16, DaleCurtis wrote:
> Thanks. mmoss: Any comments?

Nope, I'm good with it if he is. LGTM.

[DaleCurtis, 2014-05-15 17:00:49]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2014-05-15 17:01:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/190853003/60001

[commit-bot: I haz the power, 2014-05-15 17:01:33]

Change committed as 270695