Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 191553002: Switch FFmpeg from svn/git-svn translation to using git directly. (Closed)

Created:
6 years, 9 months ago by DaleCurtis
Modified:
6 years, 7 months ago
CC:
chromium-reviews, borenet2
Visibility:
Public.

Description

Switch FFmpeg from svn/git-svn translation to using git directly. Includes the deps2git roll to remove special cased ffmpeg setup. BUG=329002 TEST=gclient sync works R=mmoss@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271050

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase. Remove deps2git roll. #

Patch Set 3 : Add deps2git roll. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M DEPS View 1 2 3 chunks +3 lines, -9 lines 1 comment Download

Messages

Total messages: 19 (0 generated)
DaleCurtis
6 years, 9 months ago (2014-03-07 21:45:50 UTC) #1
szager1
https://codereview.chromium.org/191553002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/191553002/diff/1/DEPS#newcode271 DEPS:271: "/trunk/tools/deps2git@XXXXXX-CHANGE-THIS", Strictly speaking, this doesn't have to happen atomically. ...
6 years, 9 months ago (2014-03-07 22:47:03 UTC) #2
DaleCurtis
PTAL. borenet's gclient changes have landed, so once skia has switched over without issue I'll ...
6 years, 7 months ago (2014-05-13 23:52:30 UTC) #3
DaleCurtis
+mmoss since it looks like he may be rolling deps2git soon.
6 years, 7 months ago (2014-05-15 19:18:32 UTC) #4
Michael Moss
On 2014/05/15 19:18:32, DaleCurtis wrote: > +mmoss since it looks like he may be rolling ...
6 years, 7 months ago (2014-05-15 19:41:54 UTC) #5
DaleCurtis
Done.
6 years, 7 months ago (2014-05-15 19:51:41 UTC) #6
Michael Moss
lgtm
6 years, 7 months ago (2014-05-15 20:07:32 UTC) #7
DaleCurtis
Hmm, looks like borenet's change got reverted since svn left a skia/ dir around. FFmpeg ...
6 years, 7 months ago (2014-05-15 20:11:56 UTC) #8
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 7 months ago (2014-05-15 20:12:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/191553002/40001
6 years, 7 months ago (2014-05-15 20:13:40 UTC) #10
borenet
Yeah, this shouldn't have all of the problems of the Skia change... https://codereview.chromium.org/191553002/diff/40001/DEPS File DEPS ...
6 years, 7 months ago (2014-05-15 20:14:57 UTC) #11
DaleCurtis
FFmpeg isn't something we want auto-rolled at this time, so I'm okay with removing it. ...
6 years, 7 months ago (2014-05-15 20:27:33 UTC) #12
DaleCurtis
Hmm, CQ bots don't seem to be using the new DEPS file, they're instead using ...
6 years, 7 months ago (2014-05-15 20:46:47 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 00:19:37 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 00:22:17 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/68022)
6 years, 7 months ago (2014-05-16 00:22:17 UTC) #16
DaleCurtis
Going to land this manually since presubmit doesn't like the .DEPS.git changes that occur.
6 years, 7 months ago (2014-05-16 17:20:06 UTC) #17
DaleCurtis
Committed patchset #3 manually as r271050 (presubmit successful).
6 years, 7 months ago (2014-05-16 17:51:04 UTC) #18
DaleCurtis
6 years, 7 months ago (2014-05-16 18:02:46 UTC) #19
Message was sent while issue was closed.
Looking good so far,  "Conflicting directory found in ...\third_party\ffmpeg.
Removing."

Powered by Google App Engine
This is Rietveld 408576698