Add support for non-git-svn repos. Fix syntax errors.

Add support for non-git-svn repos. Fix syntax errors.

As titled, adds support for generic non-git-svn repos through
a deps_override mechanism. There were also a bevy of syntax
and style errors I fixed up too.

This shouldn't be committed until after the FFmpeg SVN repositories are updated and the DEPS rolled.

BUG=114210
TEST=Ran deps2git, gpylint.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123141

[DaleCurtis, 2012-02-14 21:39:21]

PTAL. Do we have internal git repositories too? I didn't find any mention of an
internal NewGit.

[nsylvain, 2012-02-15 17:43:39]

a few comments below.
Also adding cmp and xusydoc who were working on this earlier.

I wonder if we could instead modify the svn_to_git_public.py file to return
url@USE_REV_VAR_X_INSTEAD, and then we cue on that to do the right replacement.
It might make the change more isolated.  But if that does not make sense, then I
don't have a strong opinion again the current implementation either.

(And yes, we do have an internal file for src-internal.deps in chrome-internal)

https://chromiumcodereview.appspot.com/9359045/diff/1/deps2git.py
File deps2git.py (right):

https://chromiumcodereview.appspot.com/9359045/diff/1/deps2git.py#newcode118
deps2git.py:118: deps_overrides = {
Open question: Is there any way this code can be moved to the other file?  In
theory this code should be more generic (which is not totally the case because
of the webkit code above, but it'd be nice if we can avoid making it worse).

https://chromiumcodereview.appspot.com/9359045/diff/1/deps_utils.py
File deps_utils.py (right):

https://chromiumcodereview.appspot.com/9359045/diff/1/deps_utils.py#newcode89
deps_utils.py:89: deps = deps.replace("VAR_HASH_TEMP_%s'" % value, "' +
Var('%s')" % value)
Can you add a comment here to say that you are "trying" the replacement, but in
most cases this is a no_op.  It took me a few minutes to understand how that
worked.

[DaleCurtis, 2012-02-15 20:49:50]

https://chromiumcodereview.appspot.com/9359045/diff/1/deps2git.py
File deps2git.py (right):

https://chromiumcodereview.appspot.com/9359045/diff/1/deps2git.py#newcode118
deps2git.py:118: deps_overrides = {
On 2012/02/15 17:43:39, nsylvain wrote:
> Open question: Is there any way this code can be moved to the other file?  In
> theory this code should be more generic (which is not totally the case because
> of the webkit code above, but it'd be nice if we can avoid making it worse).
> 
> 

Which other file? I tried to be as generic as possible without assuming
responsibility for re-architecting this entire code base.

[nsylvain, 2012-02-15 21:18:05]

On Wed, Feb 15, 2012 at 12:49 PM, <dalecurtis@chromium.org> wrote:

>
>
https://chromiumcodereview.**appspot.com/9359045/diff/1/**deps2git.py<https:/...
> File deps2git.py (right):
>
> https://chromiumcodereview.**appspot.com/9359045/diff/1/**
>
deps2git.py#newcode118<https://chromiumcodereview.appspot.com/9359045/diff/1/deps2git.py#newcode118>
> deps2git.py:118: deps_overrides = {
> On 2012/02/15 17:43:39, nsylvain wrote:
>
>> Open question: Is there any way this code can be moved to the other
>>
> file?  In
>
>> theory this code should be more generic (which is not totally the case
>>
> because
>
>> of the webkit code above, but it'd be nice if we can avoid making it
>>
> worse).
>
>
>
> Which other file? I tried to be as generic as possible without assuming
> responsibility for re-architecting this entire code base.
>
I meant svn_to_git_public.py

>
>
https://chromiumcodereview.**appspot.com/9359045/<https://chromiumcodereview....
>

[DaleCurtis, 2012-02-16 02:38:37]

I've moved everything possible into svn_to_git_*, Varify gets a little more
complicated, but overall it does look cleaner.

https://chromiumcodereview.appspot.com/9359045/diff/1/deps2git.py
File deps2git.py (right):

https://chromiumcodereview.appspot.com/9359045/diff/1/deps2git.py#newcode118
deps2git.py:118: deps_overrides = {
On 2012/02/15 20:49:50, DaleCurtis wrote:
> On 2012/02/15 17:43:39, nsylvain wrote:
> > Open question: Is there any way this code can be moved to the other file? 
In
> > theory this code should be more generic (which is not totally the case
because
> > of the webkit code above, but it'd be nice if we can avoid making it worse).
> > 
> > 
> 
> Which other file? I tried to be as generic as possible without assuming
> responsibility for re-architecting this entire code base.

Done.

https://chromiumcodereview.appspot.com/9359045/diff/1/deps_utils.py
File deps_utils.py (right):

https://chromiumcodereview.appspot.com/9359045/diff/1/deps_utils.py#newcode89
deps_utils.py:89: deps = deps.replace("VAR_HASH_TEMP_%s'" % value, "' +
Var('%s')" % value)
On 2012/02/15 17:43:39, nsylvain wrote:
> Can you add a comment here to say that you are "trying" the replacement, but
in
> most cases this is a no_op.  It took me a few minutes to understand how that
> worked.

Done.

[cmp, 2012-02-16 22:10:09]

lgtm with nits

https://chromiumcodereview.appspot.com/9359045/diff/10003/deps_utils.py
File deps_utils.py (right):

https://chromiumcodereview.appspot.com/9359045/diff/10003/deps_utils.py#newco...
deps_utils.py:94: deps = deps.replace("VAR_WEBKIT_REV'", " + Var('webkit_rev')")
style on line 94 should match style on lines 91-93: use single quotes and
escaped single quotes

https://chromiumcodereview.appspot.com/9359045/diff/10003/deps_utils.py#newco...
deps_utils.py:99: lambda match: "' + Var('%s')" % match.group(1), deps)
single quotes here, too

[DaleCurtis, 2012-02-17 01:47:40]

Barring any other comments I'll push this once the ffmpeg_hash changes land
(hopefully tomorrow).

Does this run automatically or require a manual cycle?

https://chromiumcodereview.appspot.com/9359045/diff/10003/deps_utils.py
File deps_utils.py (right):

https://chromiumcodereview.appspot.com/9359045/diff/10003/deps_utils.py#newco...
deps_utils.py:94: deps = deps.replace("VAR_WEBKIT_REV'", " + Var('webkit_rev')")
On 2012/02/16 22:10:10, cmp wrote:
> style on line 94 should match style on lines 91-93: use single quotes and
> escaped single quotes

Done.

https://chromiumcodereview.appspot.com/9359045/diff/10003/deps_utils.py#newco...
deps_utils.py:99: lambda match: "' + Var('%s')" % match.group(1), deps)
On 2012/02/16 22:10:10, cmp wrote:
> single quotes here, too

Done.

[cmp, 2012-02-17 18:07:22]

On 2012/02/17 01:47:40, DaleCurtis wrote:
> Barring any other comments I'll push this once the ffmpeg_hash changes land
> (hopefully tomorrow).
> 
> Does this run automatically or require a manual cycle?

It's manual.  You'll need to ask one of us to update deps2git on the server to
match your latest changes.

[Mike Stip (use stip instead), 2012-02-17 18:09:04]

On 2012/02/17 01:47:40, DaleCurtis wrote:
 
> Does this run automatically or require a manual cycle?

Working on a patch to automatically run deps2git before compile, I don't believe
it's called by anyone else yet.

[DaleCurtis, 2012-02-22 23:56:57]

Landing, ffmpeg roll has gone in. Assuming it sticks, will need deps.git
updated.

[commit-bot: I haz the power, 2012-02-22 23:57:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/9359045/15001

[commit-bot: I haz the power, 2012-02-22 23:57:20]

Change committed as 123141