Nuke chrome.embeddedeseach.newTabPage.navigateContentWindow

Nuke chrome.embeddedeseach.newTabPage.navigateContentWindow
...and everything that was there only to support it.
After https://codereview.chromium.org/1924773002/, its special powers of navigating to file:// URLs aren't required anymore.

Manually tested:
Google remote NTP - works, including keyboard navigation.
Google local NTP - works, including keyboard navigation.
Bing NTP - works, doesn't seem to offer keyboard navigation.

BUG=584461
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/61c5a5d0d32c6b995426f802a560889242968665
Cr-Commit-Position: refs/heads/master@{#395312}

[Marc Treib, 2016-05-06 11:45:19]

Description was changed from

==========
Nuke chrome.embeddedeseach.newTabPage.navigateContentWindow
...and everything that was there only to support it.

BUG=584461
==========

to

==========
Nuke chrome.embeddedeseach.newTabPage.navigateContentWindow
...and everything that was there only to support it.
After https://codereview.chromium.org/1924773002/, its special powers of
navigating to file:// URLs aren't required anymore.

BUG=584461
==========

[Marc Treib, 2016-05-06 12:39:52]

Description was changed from

==========
Nuke chrome.embeddedeseach.newTabPage.navigateContentWindow
...and everything that was there only to support it.
After https://codereview.chromium.org/1924773002/, its special powers of
navigating to file:// URLs aren't required anymore.

BUG=584461
==========

to

==========
Nuke chrome.embeddedeseach.newTabPage.navigateContentWindow
...and everything that was there only to support it.
After https://codereview.chromium.org/1924773002/, its special powers of
navigating to file:// URLs aren't required anymore.

BUG=584461
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Marc Treib, 2016-05-06 12:40:00]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-06 12:40:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908363002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908363002/40001

[Marc Treib, 2016-05-06 13:26:42]

Description was changed from

==========
Nuke chrome.embeddedeseach.newTabPage.navigateContentWindow
...and everything that was there only to support it.
After https://codereview.chromium.org/1924773002/, its special powers of
navigating to file:// URLs aren't required anymore.

BUG=584461
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Nuke chrome.embeddedeseach.newTabPage.navigateContentWindow
...and everything that was there only to support it.
After https://codereview.chromium.org/1924773002/, its special powers of
navigating to file:// URLs aren't required anymore.

Manually tested:
Google remote NTP - works, including keyboard navigation.
Google local NTP - works, including keyboard navigation.
Bing NTP - works, doesn't seem to offer keyboard navigation.

BUG=584461
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-05-06 13:48:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 13:48:34]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-05-06 14:16:57]

treib@chromium.org changed reviewers:
+ samarth@chromium.org

[Marc Treib, 2016-05-06 14:16:58]

Hi Samarth, PTAL!

[Jered, 2016-05-06 14:20:50]

On 2016/05/06 14:16:58, Marc Treib wrote:
> Hi Samarth, PTAL!

(haven't read the code but thanks for doing this, this is long overdue.)

[Marc Treib, 2016-05-10 09:02:47]

On 2016/05/06 14:20:50, Jered wrote:
> On 2016/05/06 14:16:58, Marc Treib wrote:
> > Hi Samarth, PTAL!
> 
> (haven't read the code but thanks for doing this, this is long overdue.)

Ping!
(If Samarth is out: Jered, could you take a look?)

[Marc Treib, 2016-05-12 09:23:21]

treib@chromium.org changed reviewers:
+ jered@chromium.org, kmadhusu@chromium.org

[Marc Treib, 2016-05-12 09:23:22]

+jered +kmadhusu - Samarth seems to be out, can one of you please take a look?
thanks!

[Marc Treib, 2016-05-12 09:28:17]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 09:28:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908363002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908363002/60001

[commit-bot: I haz the power, 2016-05-12 10:48:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 10:48:16]

Dry run: This issue passed the CQ dry run.

[Jered, 2016-05-12 18:18:01]

On 2016/05/12 10:48:16, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

lgtm

[Marc Treib, 2016-05-13 08:07:41]

treib@chromium.org changed reviewers:
+ dcheng@chromium.org, msw@chromium.org, rkaplow@chromium.org

[Marc Treib, 2016-05-13 08:07:42]

Adding remaining owners for approval:

+dcheng for chrome/common/render_messages.h
+msw for chrome/browser/ui/browser.h/cc
+rkaplow for histograms

PTAL!

[rkaplow, 2016-05-13 14:11:25]

lgtm

histogram lgtm

https://codereview.chromium.org/1908363002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1908363002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:33069: +  <obsolete>
can you also mark enum as obsolete

[Marc Treib, 2016-05-13 14:32:24]

https://codereview.chromium.org/1908363002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1908363002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:33069: +  <obsolete>
On 2016/05/13 14:11:25, rkaplow wrote:
> can you also mark enum as obsolete

Done.

[dcheng, 2016-05-13 15:13:26]

lgtm

[msw, 2016-05-13 18:24:26]

chrome/browser/ui/browser.[h|cc] rubber stamp lgtm

[Marc Treib, 2016-05-23 08:28:22]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-23 08:28:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908363002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908363002/100001

[Marc Treib, 2016-05-23 08:29:39]

treib@chromium.org changed reviewers:
+ bauerb@chromium.org

[Marc Treib, 2016-05-23 08:29:39]

+bauerb - I can haz rubberstamp for chrome/browser/browser_resources.grd please?

[commit-bot: I haz the power, 2016-05-23 09:37:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-23 09:37:01]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-05-23 13:25:10]

Rubberstamp LGTM

[Marc Treib, 2016-05-23 13:50:40]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2016-05-23 13:50:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
rkaplow@chromium.org, jered@chromium.org, dcheng@chromium.org, msw@chromium.org
Link to the patchset: https://codereview.chromium.org/1908363002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-23 13:51:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908363002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908363002/100001

[commit-bot: I haz the power, 2016-05-23 13:56:57]

Description was changed from

==========
Nuke chrome.embeddedeseach.newTabPage.navigateContentWindow
...and everything that was there only to support it.
After https://codereview.chromium.org/1924773002/, its special powers of
navigating to file:// URLs aren't required anymore.

Manually tested:
Google remote NTP - works, including keyboard navigation.
Google local NTP - works, including keyboard navigation.
Bing NTP - works, doesn't seem to offer keyboard navigation.

BUG=584461
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Nuke chrome.embeddedeseach.newTabPage.navigateContentWindow
...and everything that was there only to support it.
After https://codereview.chromium.org/1924773002/, its special powers of
navigating to file:// URLs aren't required anymore.

Manually tested:
Google remote NTP - works, including keyboard navigation.
Google local NTP - works, including keyboard navigation.
Bing NTP - works, doesn't seem to offer keyboard navigation.

BUG=584461
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-05-23 13:56:59]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-23 13:58:30]

Description was changed from

==========
Nuke chrome.embeddedeseach.newTabPage.navigateContentWindow
...and everything that was there only to support it.
After https://codereview.chromium.org/1924773002/, its special powers of
navigating to file:// URLs aren't required anymore.

Manually tested:
Google remote NTP - works, including keyboard navigation.
Google local NTP - works, including keyboard navigation.
Bing NTP - works, doesn't seem to offer keyboard navigation.

BUG=584461
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Nuke chrome.embeddedeseach.newTabPage.navigateContentWindow
...and everything that was there only to support it.
After https://codereview.chromium.org/1924773002/, its special powers of
navigating to file:// URLs aren't required anymore.

Manually tested:
Google remote NTP - works, including keyboard navigation.
Google local NTP - works, including keyboard navigation.
Bing NTP - works, doesn't seem to offer keyboard navigation.

BUG=584461
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/61c5a5d0d32c6b995426f802a560889242968665
Cr-Commit-Position: refs/heads/master@{#395312}
==========

[commit-bot: I haz the power, 2016-05-23 13:58:32]

Patchset 6 (id:??) landed as
https://crrev.com/61c5a5d0d32c6b995426f802a560889242968665
Cr-Commit-Position: refs/heads/master@{#395312}