Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6783)

Unified Diff: chrome/browser/resources/local_ntp/most_visited_util.js

Issue 1908363002: Nuke chrome.embeddedeseach.newTabPage.navigateContentWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/local_ntp/most_visited_util.js
diff --git a/chrome/browser/resources/local_ntp/most_visited_util.js b/chrome/browser/resources/local_ntp/most_visited_util.js
index d0338ab1501b1c75836510f3b2961641407f948a..60e30cf7b8f832a8e26a5632caeb797da2adf522 100644
--- a/chrome/browser/resources/local_ntp/most_visited_util.js
+++ b/chrome/browser/resources/local_ntp/most_visited_util.js
@@ -8,7 +8,6 @@
*/
<include src="instant_iframe_validation.js">
-<include src="window_disposition_util.js">
/**
@@ -148,9 +147,6 @@ function createMostVisitedLink(params, href, title, text, direction, provider) {
window.parent.postMessage('linkBlurred', DOMAIN_ORIGIN);
});
- // Webkit's security policy prevents some Most Visited thumbnails from
- // working (those with schemes different from http and https). Therefore,
- // navigateContentWindow is being used in order to get all schemes working.
var navigateFunction = function handleNavigation(e) {
var isServerSuggestion = 'url' in params;
@@ -165,12 +161,7 @@ function createMostVisitedLink(params, href, title, text, direction, provider) {
provider || '');
}
- if ('rid' in params) {
- e.preventDefault();
- ntpApiHandle.navigateContentWindow(params.rid,
- getDispositionFromEvent(e));
- }
- // Else follow <a> normally, so transition type would be LINK.
+ // Follow <a> normally, so transition type will be LINK.
};
link.addEventListener('click', navigateFunction);

Powered by Google App Engine
This is Rietveld 408576698