chrome/browser/ui/search/search_ipc_router_policy_unittest.cc - Issue 1908363002: Nuke chrome.embeddedeseach.newTabPage.navigateContentWindow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/search_ipc_router_policy_unittest.cc

Issue 1908363002: Nuke chrome.embeddedeseach.newTabPage.navigateContentWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/search/search_ipc_router_policy_impl.cc ('k') | chrome/browser/ui/search/search_ipc_router_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/search/search_ipc_router_policy_unittest.cc

diff --git a/chrome/browser/ui/search/search_ipc_router_policy_unittest.cc b/chrome/browser/ui/search/search_ipc_router_policy_unittest.cc

index f3e15bc3d8c302973f0bf6c218a3ff579df0080d..5572ab7713e1a62b14e81ae4fc31f1e742f86cc1 100644

--- a/chrome/browser/ui/search/search_ipc_router_policy_unittest.cc

+++ b/chrome/browser/ui/search/search_ipc_router_policy_unittest.cc

@@ -113,19 +113,6 @@ TEST_F(SearchIPCRouterPolicyTest, DoNotProcessHistorySyncCheck) {

EXPECT_FALSE(GetSearchIPCRouterPolicy()->ShouldProcessHistorySyncCheck());

}

-TEST_F(SearchIPCRouterPolicyTest, ProcessNavigateToURL) {

- NavigateAndCommitActiveTab(GURL(chrome::kChromeSearchLocalNtpUrl));

- EXPECT_TRUE(GetSearchIPCRouterPolicy()->ShouldProcessNavigateToURL(true));

-TEST_F(SearchIPCRouterPolicyTest, DoNotProcessNavigateToURL) {

- NavigateAndCommitActiveTab(GURL("chrome-search://foo/bar"));

- EXPECT_FALSE(GetSearchIPCRouterPolicy()->ShouldProcessNavigateToURL(true));

- NavigateAndCommitActiveTab(GURL("file://foo/bar"));

- EXPECT_FALSE(GetSearchIPCRouterPolicy()->ShouldProcessNavigateToURL(true));

TEST_F(SearchIPCRouterPolicyTest, ProcessPasteIntoOmniboxMsg) {

NavigateAndCommitActiveTab(GURL(chrome::kChromeSearchLocalNtpUrl));

EXPECT_TRUE(GetSearchIPCRouterPolicy()->ShouldProcessPasteIntoOmnibox(true));

@@ -143,7 +130,6 @@ TEST_F(SearchIPCRouterPolicyTest, DoNotProcessMessagesForIncognitoPage) {

SearchIPCRouter::Policy* router_policy = GetSearchIPCRouterPolicy();

EXPECT_FALSE(router_policy->ShouldProcessFocusOmnibox(true));

- EXPECT_FALSE(router_policy->ShouldProcessNavigateToURL(true));

EXPECT_FALSE(router_policy->ShouldProcessDeleteMostVisitedItem());

EXPECT_FALSE(router_policy->ShouldProcessUndoMostVisitedDeletion());

EXPECT_FALSE(router_policy->ShouldProcessUndoAllMostVisitedDeletions());

@@ -157,7 +143,6 @@ TEST_F(SearchIPCRouterPolicyTest, DoNotProcessMessagesForInactiveTab) {

// Assume the NTP is deactivated.

SearchIPCRouter::Policy* router_policy = GetSearchIPCRouterPolicy();

EXPECT_FALSE(router_policy->ShouldProcessFocusOmnibox(false));

- EXPECT_FALSE(router_policy->ShouldProcessNavigateToURL(false));

EXPECT_FALSE(router_policy->ShouldProcessPasteIntoOmnibox(false));

EXPECT_FALSE(router_policy->ShouldSendSetInputInProgress(false));

}