Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 1907973003: media: Move audio_parameters and audio_point to media/base/ (Closed)

Created:
4 years, 8 months ago by jrummell
Modified:
4 years, 8 months ago
CC:
avayvod+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jam, jasonroberts+watch_google.com, jochen+watch_chromium.org, lcwu+watch_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-media_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, phoglund+watch_chromium.org, posciak+watch_chromium.org, tnakamura+watch_chromium.org, xjz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Move audio_parameters and audio_point to media/base/ These 2 files are used in lots of places and should be in media/base/ to clean up some dependency issues (as noted by gn check). BUG=599578 TEST=compiles with gn and gyp Committed: https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d Cr-Commit-Position: refs/heads/master@{#389216}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+376 lines, -839 lines) Patch
M chrome/browser/copresence/chrome_whispernet_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/copresence/chrome_whispernet_client_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/webrtc_audio_quality_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/webrtc_browsertest_audio.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/cast_streaming_native_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/media/cast_receiver_audio_valve.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/media/cast_rtp_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/audio/cast_audio_output_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M components/audio_modem/audio_player_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/audio_modem/audio_recorder.h View 1 chunk +1 line, -1 line 0 comments Download
M components/audio_modem/audio_recorder_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/audio_mirroring_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/media_internals.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/media_internals_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_input_debug_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_input_device_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_input_sync_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_input_sync_writer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_output_device_enumerator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_sync_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/media/audio_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/media/media_param_traits.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/speech_recognition_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/view_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/media_stream_request.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/audio_renderer_mixer_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/audio_renderer_mixer_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/audio_track_recorder.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_recorder_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_audio_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_audio_processor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_audio_sink_owner.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_audio_track_sink.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_track.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/renderer_webaudiodevice_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/speech_recognition_audio_sink.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/speech_recognition_audio_sink.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/speech_recognition_audio_sink_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webaudio_capturer_source.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/webrtc_audio_sink_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_audio_capturer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_audio_device_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_audio_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_local_audio_source_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_local_audio_source_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_local_audio_track.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_local_audio_track_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_media_stream_audio_track_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_audio_input.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/BUILD.gn View 1 1 chunk +5 lines, -5 lines 0 comments Download
M media/audio/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/alsa/alsa_input.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/alsa/alsa_output.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/alsa/audio_manager_alsa.cc View 2 chunks +1 line, -1 line 0 comments Download
M media/audio/android/audio_manager_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/android/audio_record_input.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/android/opensles_input.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/android/opensles_output.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_device_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_input_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_input_device.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_input_ipc.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_device.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_dispatcher_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_ipc.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_resampler.h View 1 chunk +1 line, -1 line 0 comments Download
D media/audio/audio_parameters.h View 1 chunk +0 lines, -222 lines 0 comments Download
D media/audio/audio_parameters.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D media/audio/audio_parameters_unittest.cc View 1 chunk +0 lines, -226 lines 0 comments Download
M media/audio/cras/cras_input.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/cras/cras_unified.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/fake_audio_input_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/fake_audio_output_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/fake_audio_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/fake_audio_worker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/mac/audio_auhal_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/mac/audio_input_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/mac/audio_low_latency_input_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/mac/audio_manager_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/mock_audio_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
D media/audio/point.h View 1 chunk +0 lines, -31 lines 0 comments Download
D media/audio/point.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D media/audio/point_unittest.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M media/audio/pulse/audio_manager_pulse.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/pulse/pulse_input.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/pulse/pulse_output.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/pulse/pulse_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/simple_sources_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/sounds/audio_stream_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/test_audio_input_controller_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/audio/virtual_audio_input_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/virtual_audio_output_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_low_latency_input_win.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_low_latency_output_win.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_manager_win.cc View 2 chunks +1 line, -1 line 0 comments Download
M media/audio/win/core_audio_util_win.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/wavein_input_win.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/waveout_output_win.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/audio_buffer_converter.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_bus.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_bus_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_capturer_source.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_converter.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_hardware_config.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_hardware_config_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + media/base/audio_parameters.h View 4 chunks +5 lines, -5 lines 0 comments Download
A + media/base/audio_parameters.cc View 1 chunk +1 line, -1 line 0 comments Download
A media/base/audio_parameters_unittest.cc View 1 chunk +226 lines, -0 lines 0 comments Download
A + media/base/audio_point.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + media/base/audio_point.cc View 1 chunk +1 line, -1 line 0 comments Download
A + media/base/audio_point_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_renderer_sink.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_splicer.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/channel_mixer.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/channel_mixer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/fake_audio_renderer_sink.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/mock_audio_renderer_sink.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/output_device_info.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/test_helpers.h View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/webaudiosourceprovider_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/test/fake_media_source.h View 1 1 chunk +1 line, -1 line 0 comments Download
M media/cast/test/receiver.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/filters/audio_renderer_algorithm.h View 1 1 chunk +1 line, -1 line 0 comments Download
M media/media.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M media/muxers/webm_muxer.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/muxers/webm_muxer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/shared_memory_support.gypi View 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/proxy/audio_input_resource.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/ppb_audio_shared.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (8 generated)
jrummell
PTAL. No code changes to the files, only whatever formatting did to the moved files. ...
4 years, 8 months ago (2016-04-21 19:28:07 UTC) #2
DaleCurtis
media/ lgtm
4 years, 8 months ago (2016-04-21 19:31:48 UTC) #3
jrummell
Adding OWNERS for the remaining directories. chrome/ sky@ chromecast/ halliwell@ content/ nasko@ ppapi/ bbudge@ This ...
4 years, 8 months ago (2016-04-21 21:51:10 UTC) #5
jrummell
+ckehoe@ as OWNER of components/audio_modem/
4 years, 8 months ago (2016-04-21 21:53:16 UTC) #7
Charlie
lgtm
4 years, 8 months ago (2016-04-21 21:57:59 UTC) #8
nasko
content/ rubberstamp LGTM
4 years, 8 months ago (2016-04-21 22:28:51 UTC) #9
bbudge
ppapi / pepper lgtm
4 years, 8 months ago (2016-04-21 22:41:21 UTC) #10
halliwell
On 2016/04/21 22:41:21, bbudge wrote: > ppapi / pepper lgtm chromecast/ lgtm
4 years, 8 months ago (2016-04-21 23:13:26 UTC) #11
sky
chrome LGTM
4 years, 8 months ago (2016-04-21 23:49:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907973003/1
4 years, 8 months ago (2016-04-22 17:20:10 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/23728) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-22 17:24:55 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907973003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907973003/20001
4 years, 8 months ago (2016-04-22 18:15:33 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-22 19:54:42 UTC) #20
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 20:00:10 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d
Cr-Commit-Position: refs/heads/master@{#389216}

Powered by Google App Engine
This is Rietveld 408576698