Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 190793011: Use isSVG*Element() helpers more in SVG code (Part 4) (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, Eric Willigers, Steve Block, krit, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), fs, Timothy Loh, dstockwell, ed+blinkwatch_opera.com, shans, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, kouhei+svg_chromium.org, dino_apple.com, rwlbuis
Visibility:
Public.

Description

Use isSVG*Element() helpers more in SVG code (Part 4) Use isSVG*Element() helpers more in SVG code. This makes the code clearer and simpler. R=pdr BUG=346095 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168807

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -80 lines) Patch
M Source/core/svg/SVGAElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimateElement.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGAnimateMotionElement.cpp View 1 chunk +18 lines, -20 lines 0 comments Download
M Source/core/svg/SVGAnimationElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEImageElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceUriElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGlyphRefElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGGraphicsElement.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGLinearGradientElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGRadialGradientElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTSpanElement.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGTextPathElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGTextPositioningElement.cpp View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 5 chunks +15 lines, -14 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 9 months ago (2014-03-09 16:32:41 UTC) #1
pdr.
On 2014/03/09 16:32:41, Chris Dumez wrote: LGTM
6 years, 9 months ago (2014-03-10 00:24:39 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-10 00:24:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/190793011/1
6 years, 9 months ago (2014-03-10 00:25:01 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 00:33:07 UTC) #5
Message was sent while issue was closed. 
Change committed as 168807

Powered by Google App Engine
This is Rietveld 408576698