Source/core/svg/SVGTSpanElement.cpp - Issue 190793011: Use isSVG*Element() helpers more in SVG code (Part 4)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGTSpanElement.cpp

Issue 190793011: Use isSVG*Element() helpers more in SVG code (Part 4) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGTSpanElement.cpp

diff --git a/Source/core/svg/SVGTSpanElement.cpp b/Source/core/svg/SVGTSpanElement.cpp

index 9aa1a9390f4a80bca5b0d844255062ef81390583..f8e2f69e461f72a71464d8f52b8b650f4903b9a6 100644

--- a/Source/core/svg/SVGTSpanElement.cpp

+++ b/Source/core/svg/SVGTSpanElement.cpp

@@ -46,13 +46,13 @@ RenderObject* SVGTSpanElement::createRenderer(RenderStyle*)

bool SVGTSpanElement::rendererIsNeeded(const RenderStyle& style)

{

if (parentNode()

- && (parentNode()->hasTagName(SVGNames::aTag)

+ && (isSVGAElement(*parentNode())

#if ENABLE(SVG_FONTS)

- || parentNode()->hasTagName(SVGNames::altGlyphTag)

+ || isSVGAltGlyphElement(*parentNode())

#endif

- || parentNode()->hasTagName(SVGNames::textTag)

- || parentNode()->hasTagName(SVGNames::textPathTag)

- || parentNode()->hasTagName(SVGNames::tspanTag)))

+ || isSVGTextElement(*parentNode())

+ || isSVGTextPathElement(*parentNode())

+ || isSVGTSpanElement(*parentNode())))

return Element::rendererIsNeeded(style);

return false;

« no previous file with comments | « Source/core/svg/SVGSVGElement.cpp ('k') | Source/core/svg/SVGTextPathElement.cpp » ('j') | no next file with comments »