Source/core/svg/SVGGlyphRefElement.cpp - Issue 190793011: Use isSVG*Element() helpers more in SVG code (Part 4)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGGlyphRefElement.cpp

Issue 190793011: Use isSVG*Element() helpers more in SVG code (Part 4) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGGlyphRefElement.cpp

diff --git a/Source/core/svg/SVGGlyphRefElement.cpp b/Source/core/svg/SVGGlyphRefElement.cpp

index 945491d515d1c54fb6b71b2ea86461e8ba1859ae..1d62b08b71c449fc4265b2433a3a0bfc746ef13c 100644

--- a/Source/core/svg/SVGGlyphRefElement.cpp

+++ b/Source/core/svg/SVGGlyphRefElement.cpp

@@ -49,9 +49,7 @@ bool SVGGlyphRefElement::hasValidGlyphElement(AtomicString& glyphName) const

// FIXME: We only support xlink:href so far.

// https://bugs.webkit.org/show_bug.cgi?id=64787

Element* element = targetElementFromIRIString(getAttribute(XLinkNames::hrefAttr), document(), &glyphName);

- if (!element || !element->hasTagName(SVGNames::glyphTag))

- return false;

- return true;

+ return isSVGGlyphElement(element);

}

template<typename CharType>

« no previous file with comments | « Source/core/svg/SVGFontFaceUriElement.cpp ('k') | Source/core/svg/SVGGraphicsElement.cpp » ('j') | no next file with comments »