Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7687)

Unified Diff: chrome/common/extensions/api/passwords_private.idl

Issue 1907813002: Make the URLs in the password exceptions list clickable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-implicit-update.gitbr
Patch Set: feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/passwords_private.idl
diff --git a/chrome/common/extensions/api/passwords_private.idl b/chrome/common/extensions/api/passwords_private.idl
index 9eac0a1deb09eb1d5971205f838eb6c844bc1ab7..58e03e5fcbaee6e02175367f224c411822d82dbd 100644
--- a/chrome/common/extensions/api/passwords_private.idl
+++ b/chrome/common/extensions/api/passwords_private.idl
@@ -19,7 +19,7 @@ namespace passwordsPrivate {
// The login information for this entry.
LoginPair loginPair;
- // The URL that should be linked to when clicking in the UI.
+ // The complete URL of the page that the password is saved for.
DOMString linkUrl;
// The number of characters in the password; used to display placeholder
@@ -30,6 +30,14 @@ namespace passwordsPrivate {
DOMString? federationText;
};
+ dictionary ExceptionPair {
+ // The human-readable URL where passwords will not be saved.
+ DOMString exceptionUrl;
+
+ // The complete URL of the page that the exception was created for.
+ DOMString linkUrl;
+ };
+
// Dictionary passed to listeners for the onPlaintextPasswordRetrieved event.
dictionary PlaintextPasswordEventParameters {
// The LoginPair associated with the retrieved password.
@@ -40,7 +48,7 @@ namespace passwordsPrivate {
};
callback PasswordListCallback = void(PasswordUiEntry[] entries);
- callback ExceptionListCallback = void(DOMString[] exceptions);
+ callback ExceptionListCallback = void(ExceptionPair[] exceptions);
interface Functions {
// Removes the saved password corresponding to |loginPair|. If no saved
@@ -85,7 +93,7 @@ namespace passwordsPrivate {
// entry has been added or removed.
//
// |exceptions|: The updated list of password exceptions.
- static void onPasswordExceptionsListChanged(DOMString[] exceptions);
+ static void onPasswordExceptionsListChanged(ExceptionPair[] exceptions);
// Fired when a plaintext password has been fetched in response to a call to
// chrome.passwordsPrivate.requestPlaintextPassword().

Powered by Google App Engine
This is Rietveld 408576698