Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2606)

Unified Diff: chrome/test/data/extensions/api_test/passwords_private/test.js

Issue 1907813002: Make the URLs in the password exceptions list clickable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-implicit-update.gitbr
Patch Set: feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/passwords_private/test.js
diff --git a/chrome/test/data/extensions/api_test/passwords_private/test.js b/chrome/test/data/extensions/api_test/passwords_private/test.js
index 79f4cde5d42bbab1712173f37e1a4776afb2d51a..b1ae4f5f6f77d7f3e66c7080afb871db53827858 100644
--- a/chrome/test/data/extensions/api_test/passwords_private/test.js
+++ b/chrome/test/data/extensions/api_test/passwords_private/test.js
@@ -41,7 +41,7 @@ var availableTests = [
if (numCalls == 1) {
numPasswordExceptions = passwordExceptionsList.length;
chrome.passwordsPrivate.removePasswordException(
- passwordExceptionsList[0]);
+ passwordExceptionsList[0].exceptionUrl);
} else if (numCalls == 2) {
chrome.test.assertEq(
passwordExceptionsList.length, numPasswordExceptions - 1);
@@ -70,6 +70,15 @@ var availableTests = [
function getSavedPasswordList() {
var callback = function(list) {
chrome.test.assertTrue(!!list);
+ chrome.test.assertTrue(list.length > 0);
+
+ for (var i = 0; i < list.length; ++i) {
+ var entry = list[i];
+ chrome.test.assertTrue(!!entry.loginPair);
+ chrome.test.assertTrue(!!entry.loginPair.originUrl);
+ chrome.test.assertTrue(!!entry.linkUrl);
+ }
+
// Ensure that the callback is invoked.
chrome.test.succeed();
};
@@ -80,6 +89,14 @@ var availableTests = [
function getPasswordExceptionList() {
var callback = function(list) {
chrome.test.assertTrue(!!list);
+ chrome.test.assertTrue(list.length > 0);
+
+ for (var i = 0; i < list.length; ++i) {
+ var exception = list[i];
+ chrome.test.assertTrue(!!exception.exceptionUrl);
+ chrome.test.assertTrue(!!exception.linkUrl);
+ }
+
// Ensure that the callback is invoked.
chrome.test.succeed();
};

Powered by Google App Engine
This is Rietveld 408576698