chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js - Issue 1907813002: Make the URLs in the password exceptions list clickable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

Issue 1907813002: Make the URLs in the password exceptions list clickable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-implicit-update.gitbr

Patch Set: feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html ('k') | chrome/common/extensions/api/passwords_private.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

index ea16cf493dcfb6fe11c63bad0a988c49e7d61e94..447315621d0c1da87d7dedcaa431f44b0af3110e 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

@@ -11,6 +11,9 @@

/** @typedef {!{model: !{item: !chrome.passwordsPrivate.PasswordUiEntry}}} */

var PasswordUiEntryEvent;

+/** @typedef {!{model: !{item: !chrome.passwordsPrivate.ExceptionPair}}} */

+var ExceptionPairEntryEvent;

(function() {

'use strict';

@@ -37,7 +40,7 @@ Polymer({

/**

* An array of sites to display.

- * @type {!Array<!string>}

+ * @type {!Array<!chrome.passwordsPrivate.ExceptionPair>}

passwordExceptions: {

type: Array,

@@ -91,11 +94,11 @@ Polymer({

/**

* Fires an event that should delete the password exception.

- * @param {!{model: !{item: !string}}} e The polymer event.

+ * @param {!ExceptionPairEntryEvent} e The polymer event.

* @private

onRemoveExceptionButtonTap_: function(e) {

- this.fire('remove-password-exception', e.model.item);

+ this.fire('remove-password-exception', e.model.item.exceptionUrl);

/**