Delete //gpu/blink/ and WebGraphicsContext3DImpl.

Delete //gpu/blink/ and WebGraphicsContext3DImpl.

There is now only 1 subclass of WebGraphicsContext3DImpl (which is the
infamous WebGraphicsContext3DCommandBufferImpl), so let's delete this
in-between thing.

The use of GLES2TraceImplementation was broken, since
ContextProviderCommandBuffer was returning the underlying
GLES2Implementation directly now (woops). Fix that and move it to
the ContextProviderCommandBuffer.

Move the lost context callback to WebGraphicsContext3DCommandBufferImpl,
and remove the definition of the proxy class out of WebGraphicsContext3D
leaving the blink base class empty now.

Lots of DEPS and include removals all over the place that were already
obsolete.

R=piman, sievers
TBR=chrishtr
BUG=584497
Committed: https://crrev.com/405d011dea3e17b9b70716a7f425b07c03183884
Cr-Commit-Position: refs/heads/master@{#389257}

[danakj, 2016-04-21 00:27:52]

Description was changed from

==========
Delete //gpu/blink/ and WebGraphicsContext3DImpl.

There is now only 1 subclass of WebGraphicsContext3DImpl (which is the
infamous WebGraphicsContext3DCommandBufferImpl), so let's delete this
in-between thing.

The use of GLES2TraceImplementation was broken, fix it and move it to
the ContextProviderCommandBuffer.

Move the lost context callback to WebGraphicsContext3DCommandBufferImpl.

Lots of DEPS and include removals all over the place.

R=piman, sievers
BUG=584497
==========

to

==========
Delete //gpu/blink/ and WebGraphicsContext3DImpl.

There is now only 1 subclass of WebGraphicsContext3DImpl (which is the
infamous WebGraphicsContext3DCommandBufferImpl), so let's delete this
in-between thing.

The use of GLES2TraceImplementation was broken, fix it and move it to
the ContextProviderCommandBuffer.

Move the lost context callback to WebGraphicsContext3DCommandBufferImpl.

Lots of DEPS and include removals all over the place.

R=piman, sievers
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[danakj, 2016-04-21 00:28:28]

Description was changed from

==========
Delete //gpu/blink/ and WebGraphicsContext3DImpl.

There is now only 1 subclass of WebGraphicsContext3DImpl (which is the
infamous WebGraphicsContext3DCommandBufferImpl), so let's delete this
in-between thing.

The use of GLES2TraceImplementation was broken, fix it and move it to
the ContextProviderCommandBuffer.

Move the lost context callback to WebGraphicsContext3DCommandBufferImpl.

Lots of DEPS and include removals all over the place.

R=piman, sievers
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Delete //gpu/blink/ and WebGraphicsContext3DImpl.

There is now only 1 subclass of WebGraphicsContext3DImpl (which is the
infamous WebGraphicsContext3DCommandBufferImpl), so let's delete this
in-between thing.

The use of GLES2TraceImplementation was broken, since
ContextProviderCommandBuffer was returning the underlying
GLES2Implementation directly now (woops). Fix that and move it to
the ContextProviderCommandBuffer.

Move the lost context callback to WebGraphicsContext3DCommandBufferImpl.

Lots of DEPS and include removals all over the place that were already
obsolete.

R=piman, sievers
BUG=584497
==========

[danakj, 2016-04-21 00:29:39]

Description was changed from

==========
Delete //gpu/blink/ and WebGraphicsContext3DImpl.

There is now only 1 subclass of WebGraphicsContext3DImpl (which is the
infamous WebGraphicsContext3DCommandBufferImpl), so let's delete this
in-between thing.

The use of GLES2TraceImplementation was broken, since
ContextProviderCommandBuffer was returning the underlying
GLES2Implementation directly now (woops). Fix that and move it to
the ContextProviderCommandBuffer.

Move the lost context callback to WebGraphicsContext3DCommandBufferImpl.

Lots of DEPS and include removals all over the place that were already
obsolete.

R=piman, sievers
BUG=584497
==========

to

==========
Delete //gpu/blink/ and WebGraphicsContext3DImpl.

There is now only 1 subclass of WebGraphicsContext3DImpl (which is the
infamous WebGraphicsContext3DCommandBufferImpl), so let's delete this
in-between thing.

The use of GLES2TraceImplementation was broken, since
ContextProviderCommandBuffer was returning the underlying
GLES2Implementation directly now (woops). Fix that and move it to
the ContextProviderCommandBuffer.

Move the lost context callback to WebGraphicsContext3DCommandBufferImpl,
and remove the definition of the proxy class out of WebGraphicsContext3D
leaving the blink base class empty now.

Lots of DEPS and include removals all over the place that were already
obsolete.

R=piman, sievers
BUG=584497
==========

[danakj, 2016-04-21 00:29:40]

danakj@chromium.org changed reviewers:
+ boliu@chromium.org, chrishtr@chromium.org, dalecurtis@chromium.org

[danakj, 2016-04-21 00:30:10]

Usual suspects for review please :)

piman: everything
boliu: webview
dalecurtis: media
chrishtr: public

[Ken Russell (switch to Gerrit), 2016-04-21 00:31:01]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-04-21 00:31:02]

Awesome!

[danakj, 2016-04-21 00:31:28]

Description was changed from

==========
Delete //gpu/blink/ and WebGraphicsContext3DImpl.

There is now only 1 subclass of WebGraphicsContext3DImpl (which is the
infamous WebGraphicsContext3DCommandBufferImpl), so let's delete this
in-between thing.

The use of GLES2TraceImplementation was broken, since
ContextProviderCommandBuffer was returning the underlying
GLES2Implementation directly now (woops). Fix that and move it to
the ContextProviderCommandBuffer.

Move the lost context callback to WebGraphicsContext3DCommandBufferImpl,
and remove the definition of the proxy class out of WebGraphicsContext3D
leaving the blink base class empty now.

Lots of DEPS and include removals all over the place that were already
obsolete.

R=piman, sievers
BUG=584497
==========

to

==========
Delete //gpu/blink/ and WebGraphicsContext3DImpl.

There is now only 1 subclass of WebGraphicsContext3DImpl (which is the
infamous WebGraphicsContext3DCommandBufferImpl), so let's delete this
in-between thing.

The use of GLES2TraceImplementation was broken, since
ContextProviderCommandBuffer was returning the underlying
GLES2Implementation directly now (woops). Fix that and move it to
the ContextProviderCommandBuffer.

Move the lost context callback to WebGraphicsContext3DCommandBufferImpl,
and remove the definition of the proxy class out of WebGraphicsContext3D
leaving the blink base class empty now.

Lots of DEPS and include removals all over the place that were already
obsolete.

R=piman, sievers
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[boliu, 2016-04-21 00:35:10]

lgtm \o/

[danakj, 2016-04-21 00:35:22]

Patchset #2 (id:20001) has been deleted

[DaleCurtis, 2016-04-21 00:35:28]

media/ lgtm

[danakj, 2016-04-21 00:35:28]

Patchset #1 (id:1) has been deleted

[danakj, 2016-04-21 00:38:42]

https://codereview.chromium.org/1907783002/diff/40001/content/common/gpu/clie...
File content/common/gpu/client/context_provider_command_buffer.cc (right):

https://codereview.chromium.org/1907783002/diff/40001/content/common/gpu/clie...
content/common/gpu/client/context_provider_command_buffer.cc:128: if
(trace_impl_)
We *could* avoid a branch here and put a GLES2Interface* on the provider
instead. Worth?

https://codereview.chromium.org/1907783002/diff/40001/content/common/gpu/clie...
File content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc
(left):

https://codereview.chromium.org/1907783002/diff/40001/content/common/gpu/clie...
content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc:283:
gpu::gles2::GLES2Interface* gl = GetGLInterface();
Since we no longer know the tracing interface only the GLES2Impl here, I moved
the flush to the ContextProviderCommandBuffer destructor.

[piman, 2016-04-21 00:43:31]

lgtm

[piman, 2016-04-21 00:44:21]

https://codereview.chromium.org/1907783002/diff/40001/content/common/gpu/clie...
File content/common/gpu/client/context_provider_command_buffer.cc (right):

https://codereview.chromium.org/1907783002/diff/40001/content/common/gpu/clie...
content/common/gpu/client/context_provider_command_buffer.cc:128: if
(trace_impl_)
On 2016/04/21 00:38:41, danakj wrote:
> We *could* avoid a branch here and put a GLES2Interface* on the provider
> instead. Worth?

I was thinking about it, but decided that this is probably not called too often
(is it?).

[danakj, 2016-04-21 00:52:44]

https://codereview.chromium.org/1907783002/diff/40001/content/common/gpu/clie...
File content/common/gpu/client/context_provider_command_buffer.cc (right):

https://codereview.chromium.org/1907783002/diff/40001/content/common/gpu/clie...
content/common/gpu/client/context_provider_command_buffer.cc:128: if
(trace_impl_)
On 2016/04/21 00:44:21, piman wrote:
> On 2016/04/21 00:38:41, danakj wrote:
> > We *could* avoid a branch here and put a GLES2Interface* on the provider
> > instead. Worth?
> 
> I was thinking about it, but decided that this is probably not called too
often
> (is it?).

I think we normally cache the result if we call it a lot, cuz it's a virtual
function.

[danakj, 2016-04-21 01:03:25]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-04-21 01:03:26]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org,
piman@chromium.org, dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1907783002/#ps60001
(title: "rm-webgraphicscontext3dimpl: rebase")

[commit-bot: I haz the power, 2016-04-21 01:03:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907783002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907783002/60001

[danakj, 2016-04-21 01:04:05]

TBR'ing chris for public/

[danakj, 2016-04-21 01:04:13]

Description was changed from

==========
Delete //gpu/blink/ and WebGraphicsContext3DImpl.

There is now only 1 subclass of WebGraphicsContext3DImpl (which is the
infamous WebGraphicsContext3DCommandBufferImpl), so let's delete this
in-between thing.

The use of GLES2TraceImplementation was broken, since
ContextProviderCommandBuffer was returning the underlying
GLES2Implementation directly now (woops). Fix that and move it to
the ContextProviderCommandBuffer.

Move the lost context callback to WebGraphicsContext3DCommandBufferImpl,
and remove the definition of the proxy class out of WebGraphicsContext3D
leaving the blink base class empty now.

Lots of DEPS and include removals all over the place that were already
obsolete.

R=piman, sievers
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Delete //gpu/blink/ and WebGraphicsContext3DImpl.

There is now only 1 subclass of WebGraphicsContext3DImpl (which is the
infamous WebGraphicsContext3DCommandBufferImpl), so let's delete this
in-between thing.

The use of GLES2TraceImplementation was broken, since
ContextProviderCommandBuffer was returning the underlying
GLES2Implementation directly now (woops). Fix that and move it to
the ContextProviderCommandBuffer.

Move the lost context callback to WebGraphicsContext3DCommandBufferImpl,
and remove the definition of the proxy class out of WebGraphicsContext3D
leaving the blink base class empty now.

Lots of DEPS and include removals all over the place that were already
obsolete.

R=piman, sievers
TBR=chrishtr
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[danakj, 2016-04-21 01:04:21]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-04-21 01:04:27]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-04-21 01:04:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907783002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907783002/60001

[commit-bot: I haz the power, 2016-04-21 01:26:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 01:26:55]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2016-04-21 15:24:51]

lgtm

[danakj, 2016-04-22 00:38:07]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-04-22 00:38:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, boliu@chromium.org, piman@chromium.org,
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1907783002/#ps100001
(title: "rm-webgraphicscontext3dimpl: noflush")

[commit-bot: I haz the power, 2016-04-22 00:38:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907783002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907783002/100001

[danakj, 2016-04-22 00:38:53]

https://codereview.chromium.org/1907783002/diff/60001/content/common/gpu/clie...
File content/common/gpu/client/context_provider_command_buffer.cc (right):

https://codereview.chromium.org/1907783002/diff/60001/content/common/gpu/clie...
content/common/gpu/client/context_provider_command_buffer.cc:75:
ContextGL()->Flush();
This line got the ContextGL() after unsetting the lost_context_callback_proxy_
which would simply DCHECK saying we didn't BindToCurrenThread yet.

Daniel pointed out that GLES2Implementation will do a glFinish() from its
destructor already, and flush is not sufficient anyways. So I'll just drop this
Flush entirely.

[commit-bot: I haz the power, 2016-04-22 01:40:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 01:40:27]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2016-04-22 20:26:22]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-04-22 20:26:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907783002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907783002/100001

[danakj, 2016-04-22 21:48:26]

The WebglConformance.deqp_functional_gles3_shaderswitch test passes for me
locally and the bot seems to be very behind, so I'll skip past it.

[danakj, 2016-04-22 21:48:33]

Description was changed from

==========
Delete //gpu/blink/ and WebGraphicsContext3DImpl.

There is now only 1 subclass of WebGraphicsContext3DImpl (which is the
infamous WebGraphicsContext3DCommandBufferImpl), so let's delete this
in-between thing.

The use of GLES2TraceImplementation was broken, since
ContextProviderCommandBuffer was returning the underlying
GLES2Implementation directly now (woops). Fix that and move it to
the ContextProviderCommandBuffer.

Move the lost context callback to WebGraphicsContext3DCommandBufferImpl,
and remove the definition of the proxy class out of WebGraphicsContext3D
leaving the blink base class empty now.

Lots of DEPS and include removals all over the place that were already
obsolete.

R=piman, sievers
TBR=chrishtr
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Delete //gpu/blink/ and WebGraphicsContext3DImpl.

There is now only 1 subclass of WebGraphicsContext3DImpl (which is the
infamous WebGraphicsContext3DCommandBufferImpl), so let's delete this
in-between thing.

The use of GLES2TraceImplementation was broken, since
ContextProviderCommandBuffer was returning the underlying
GLES2Implementation directly now (woops). Fix that and move it to
the ContextProviderCommandBuffer.

Move the lost context callback to WebGraphicsContext3DCommandBufferImpl,
and remove the definition of the proxy class out of WebGraphicsContext3D
leaving the blink base class empty now.

Lots of DEPS and include removals all over the place that were already
obsolete.

R=piman, sievers
TBR=chrishtr
BUG=584497
==========

[danakj, 2016-04-22 21:48:37]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-04-22 21:48:45]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-04-22 21:49:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907783002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907783002/100001

[Ken Russell (switch to Gerrit), 2016-04-22 21:54:06]

On 2016/04/22 21:48:26, danakj wrote:
> The WebglConformance.deqp_functional_gles3_shaderswitch test passes for me
> locally and the bot seems to be very behind, so I'll skip past it.

Sorry about that flakiness; I can't reproduce it either. It's been suppressed in
https://codereview.chromium.org/1904273003 .

[commit-bot: I haz the power, 2016-04-22 21:57:27]

Description was changed from

==========
Delete //gpu/blink/ and WebGraphicsContext3DImpl.

There is now only 1 subclass of WebGraphicsContext3DImpl (which is the
infamous WebGraphicsContext3DCommandBufferImpl), so let's delete this
in-between thing.

The use of GLES2TraceImplementation was broken, since
ContextProviderCommandBuffer was returning the underlying
GLES2Implementation directly now (woops). Fix that and move it to
the ContextProviderCommandBuffer.

Move the lost context callback to WebGraphicsContext3DCommandBufferImpl,
and remove the definition of the proxy class out of WebGraphicsContext3D
leaving the blink base class empty now.

Lots of DEPS and include removals all over the place that were already
obsolete.

R=piman, sievers
TBR=chrishtr
BUG=584497
==========

to

==========
Delete //gpu/blink/ and WebGraphicsContext3DImpl.

There is now only 1 subclass of WebGraphicsContext3DImpl (which is the
infamous WebGraphicsContext3DCommandBufferImpl), so let's delete this
in-between thing.

The use of GLES2TraceImplementation was broken, since
ContextProviderCommandBuffer was returning the underlying
GLES2Implementation directly now (woops). Fix that and move it to
the ContextProviderCommandBuffer.

Move the lost context callback to WebGraphicsContext3DCommandBufferImpl,
and remove the definition of the proxy class out of WebGraphicsContext3D
leaving the blink base class empty now.

Lots of DEPS and include removals all over the place that were already
obsolete.

R=piman, sievers
TBR=chrishtr
BUG=584497
==========

[commit-bot: I haz the power, 2016-04-22 21:57:30]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-04-22 21:59:10]

Description was changed from

==========
Delete //gpu/blink/ and WebGraphicsContext3DImpl.

There is now only 1 subclass of WebGraphicsContext3DImpl (which is the
infamous WebGraphicsContext3DCommandBufferImpl), so let's delete this
in-between thing.

The use of GLES2TraceImplementation was broken, since
ContextProviderCommandBuffer was returning the underlying
GLES2Implementation directly now (woops). Fix that and move it to
the ContextProviderCommandBuffer.

Move the lost context callback to WebGraphicsContext3DCommandBufferImpl,
and remove the definition of the proxy class out of WebGraphicsContext3D
leaving the blink base class empty now.

Lots of DEPS and include removals all over the place that were already
obsolete.

R=piman, sievers
TBR=chrishtr
BUG=584497
==========

to

==========
Delete //gpu/blink/ and WebGraphicsContext3DImpl.

There is now only 1 subclass of WebGraphicsContext3DImpl (which is the
infamous WebGraphicsContext3DCommandBufferImpl), so let's delete this
in-between thing.

The use of GLES2TraceImplementation was broken, since
ContextProviderCommandBuffer was returning the underlying
GLES2Implementation directly now (woops). Fix that and move it to
the ContextProviderCommandBuffer.

Move the lost context callback to WebGraphicsContext3DCommandBufferImpl,
and remove the definition of the proxy class out of WebGraphicsContext3D
leaving the blink base class empty now.

Lots of DEPS and include removals all over the place that were already
obsolete.

R=piman, sievers
TBR=chrishtr
BUG=584497

Committed: https://crrev.com/405d011dea3e17b9b70716a7f425b07c03183884
Cr-Commit-Position: refs/heads/master@{#389257}
==========

[commit-bot: I haz the power, 2016-04-22 21:59:12]

Patchset 4 (id:??) landed as
https://crrev.com/405d011dea3e17b9b70716a7f425b07c03183884
Cr-Commit-Position: refs/heads/master@{#389257}