Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1907073002: Update cpu and memory metric calculation and several small improvements. (Closed)

Created:
4 years, 8 months ago by Lei Lei
Modified:
4 years, 8 months ago
Reviewers:
imcheng, apacible
CC:
chromium-reviews, media-router+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update cpu and memory metric calculation and several small improvements. - Get rid of all the zero values when calculate the average value. - Add mr_extension_wakeup_percentage metric to show how long the mr extesion is active during the test. - Start to collect data after start a new session and load the media for flinging case, so we will only get the results after the cast session is stable. - Use internal video instead of public one in continuous test. BUG=594225 Committed: https://crrev.com/667c742c4b79846571ea9c1817e4e19467132420 Cr-Commit-Position: refs/heads/master@{#389640}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed Jennifer's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -30 lines) Patch
M chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py View 1 2 chunks +13 lines, -3 lines 0 comments Download
M chrome/test/media_router/telemetry/benchmarks/pagesets/cpu_memory_script.js View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_perf_pages.py View 5 chunks +14 lines, -23 lines 0 comments Download
M chrome/test/media_router/telemetry/media_router_config.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Lei Lei
4 years, 8 months ago (2016-04-21 21:51:16 UTC) #2
apacible
lgtm https://codereview.chromium.org/1907073002/diff/1/chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py File chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py (right): https://codereview.chromium.org/1907073002/diff/1/chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py#newcode59 chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py:59: 2) nit: indent
4 years, 8 months ago (2016-04-22 16:51:35 UTC) #3
Lei Lei
https://codereview.chromium.org/1907073002/diff/1/chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py File chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py (right): https://codereview.chromium.org/1907073002/diff/1/chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py#newcode59 chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py:59: 2) On 2016/04/22 16:51:35, apacible wrote: > nit: indent ...
4 years, 8 months ago (2016-04-22 22:27:40 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907073002/20001
4 years, 8 months ago (2016-04-22 23:49:26 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-23 00:26:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907073002/20001
4 years, 8 months ago (2016-04-26 00:03:00 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-26 00:41:59 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 00:44:01 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/667c742c4b79846571ea9c1817e4e19467132420
Cr-Commit-Position: refs/heads/master@{#389640}

Powered by Google App Engine
This is Rietveld 408576698