Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5585)

Unified Diff: chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py

Issue 1907073002: Update cpu and memory metric calculation and several small improvements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Jennifer's comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/media_router/telemetry/benchmarks/pagesets/cpu_memory_script.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py
diff --git a/chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py b/chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py
index b7ca295cda986adfbebe03302160d2a0f4b6d940..c44a8431c8622f79200d168df575ebfd30b7649a 100644
--- a/chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py
+++ b/chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py
@@ -12,7 +12,7 @@ from metrics import Metric
METRICS = {'privateMemory': {'units': 'MB', 'display_name': 'private_memory'},
- 'cpu': {'units': '%', 'display_name': 'cpu_utilization'}}
+ 'cpu': {'units': '%', 'display_name': 'cpu_utilization'}}
class MediaRouterCPUMemoryMetric(Metric):
@@ -41,11 +41,21 @@ class MediaRouterCPUMemoryMetric(Metric):
for (process, process_results) in metric_results.iteritems():
if not process_results:
continue
- avg_result = round(sum(process_results)/len(process_results), 4)
+ # Get rid of 0 values
+ non_zero_results = [result for result in process_results if result]
+ avg_result = round(sum(non_zero_results)/len(non_zero_results), 4)
if metric == 'privateMemory':
avg_result = round(avg_result/(1024 * 1024), 2)
results.AddValue(scalar.ScalarValue(
results.current_page,
- '%s.%s' % (METRICS.get(metric).get('display_name'), process),
+ '%s_%s' % (METRICS.get(metric).get('display_name'), process),
METRICS.get(metric).get('units'),
avg_result))
+
+ # Calculate MR extension wakeup time
+ wakeup_percentage = round(
+ (len(perf_results['cpu']['mr_extension']) * 100 /
+ len(perf_results['cpu']['browser'])), 2)
+ results.AddValue(scalar.ScalarValue(
+ results.current_page, 'mr_extension_wakeup_percentage',
+ '%', wakeup_percentage))
« no previous file with comments | « no previous file | chrome/test/media_router/telemetry/benchmarks/pagesets/cpu_memory_script.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698