chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py - Issue 1907073002: Update cpu and memory metric calculation and several small improvements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py

Issue 1907073002: Update cpu and memory metric calculation and several small improvements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Jennifer's comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/media_router/telemetry/benchmarks/pagesets/cpu_memory_script.js ('k') | chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_perf_pages.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py

diff --git a/chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py b/chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py

index 1ba7fa781e4acb3e1a6630a0a09556d754ba3324..538d99b22ea165f7d70d8263921b1be46f2ff82f 100644

--- a/chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py

+++ b/chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_page.py

@@ -4,6 +4,7 @@

import os

import time

+import utils

from telemetry import page

from telemetry import story

@@ -59,8 +60,9 @@ class CastPage(page.Page):

def _GetDeviceName(self):

"""Gets device name from environment variable RECEIVER_NAME."""

- if 'RECEIVER_NAME' not in os.environ or not os.environ.get('RECEIVER_NAME'):

+ if 'RECEIVER_IP' not in os.environ or not os.environ.get('RECEIVER_IP'):

raise page.page_test.Failure(

'Your test machine is not set up correctly, '

- 'RECEIVER_NAME enviroment variable is missing.')

- return os.environ.get('RECEIVER_NAME')

+ 'RECEIVER_IP enviroment variable is missing.')

+ return utils.GetDeviceName(os.environ.get('RECEIVER_IP'))