Convert //components/prefs from scoped_ptr to std::unique_ptr

Convert //components/prefs from scoped_ptr to std::unique_ptr

BUG=554298
R=gab@chromium.org

Committed: https://crrev.com/5f043bc0ea7c069e3ef5e6ef903b98f4e84ec4cb
Cr-Commit-Position: refs/heads/master@{#389198}

[dcheng, 2016-04-21 21:34:03]

dcheng@chromium.org changed reviewers:
+ asvitkine@chromium.org

[dcheng, 2016-04-21 21:34:04]

This is largely a search and replace. There's probably some IWYU errors (files
that don't include memory when they should and those that do when they
shouldn't), but fixing those is out-of-scope for this conversion work.

+asvitkine@ for changes in //components/{flag_ui,metrics,web_resource} changes.
+gab for primary review in //components/prefs and remaining IWYU fixes.

Note that in this case, I chose to add a scoped_ptr.h include: all the failures
I inspected should have an #include for scoped_ptr.h anyway. Doing this also
reduces the amount of inter-component conflicts (e.g. with the current CL for
//components/metrics). There will be a final pass over the codebase to fixup
stray and no longer needed scoped_ptr.h includes before removing the header for
good, so it won't be a problem.

[Alexei Svitkine (slow), 2016-04-21 21:35:24]

lgtm for components/metrics

[gab, 2016-04-22 18:23:08]

lgtm % comment

https://codereview.chromium.org/1907043002/diff/20001/components/user_prefs/t...
File components/user_prefs/tracked/interceptable_pref_filter.h (right):

https://codereview.chromium.org/1907043002/diff/20001/components/user_prefs/t...
components/user_prefs/tracked/interceptable_pref_filter.h:9: #include
"base/memory/scoped_ptr.h"
Doesn't this conflict with https://codereview.chromium.org/1908143002/ ?

[dcheng, 2016-04-22 18:26:19]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-22 18:26:20]

https://codereview.chromium.org/1907043002/diff/20001/components/user_prefs/t...
File components/user_prefs/tracked/interceptable_pref_filter.h (right):

https://codereview.chromium.org/1907043002/diff/20001/components/user_prefs/t...
components/user_prefs/tracked/interceptable_pref_filter.h:9: #include
"base/memory/scoped_ptr.h"
On 2016/04/22 at 18:23:08, gab wrote:
> Doesn't this conflict with https://codereview.chromium.org/1908143002/ ?

Not really. It's a legitimate IWYU error. After that CL lands, this file won't
need to #include scoped_ptr.h anymore... but there will be a final cleanup pass
throughout the codebase to change remaining references to
base/memory/scoped_ptr.h to point to <memory>. That will magically fix this file
and also make it IWYU compliant. While it leads to temporary inconsistencies, it
lets the overall conversion be parallelized and completed more quickly.

[commit-bot: I haz the power, 2016-04-22 18:27:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907043002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907043002/20001

[commit-bot: I haz the power, 2016-04-22 19:09:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:51:07]

Description was changed from

==========
Convert //components/prefs from scoped_ptr to std::unique_ptr

BUG=554298
R=gab@chromium.org
==========

to

==========
Convert //components/prefs from scoped_ptr to std::unique_ptr

BUG=554298
R=gab@chromium.org

Committed: https://crrev.com/5f043bc0ea7c069e3ef5e6ef903b98f4e84ec4cb
Cr-Commit-Position: refs/heads/master@{#389198}
==========

[commit-bot: I haz the power, 2016-04-22 19:51:08]

Patchset 2 (id:??) landed as
https://crrev.com/5f043bc0ea7c069e3ef5e6ef903b98f4e84ec4cb
Cr-Commit-Position: refs/heads/master@{#389198}