components/prefs/overlay_user_pref_store.h - Issue 1907043002: Convert //components/prefs from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/prefs/overlay_user_pref_store.h

Issue 1907043002: Convert //components/prefs from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IWYU fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/prefs/json_pref_store_unittest.cc ('k') | components/prefs/overlay_user_pref_store.cc » ('j') | components/user_prefs/tracked/interceptable_pref_filter.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/prefs/overlay_user_pref_store.h

diff --git a/components/prefs/overlay_user_pref_store.h b/components/prefs/overlay_user_pref_store.h

index c3382c25d4e0e3af4a5870298c63c686f18f2329..e3ad88e16688865c4237c4d447f2c5f15776d181 100644

--- a/components/prefs/overlay_user_pref_store.h

+++ b/components/prefs/overlay_user_pref_store.h

@@ -42,10 +42,10 @@ class COMPONENTS_PREFS_EXPORT OverlayUserPrefStore : public PersistentPrefStore,

// Methods of PersistentPrefStore.

bool GetMutableValue(const std::string& key, base::Value** result) override;

void SetValue(const std::string& key,

- scoped_ptr<base::Value> value,

+ std::unique_ptr<base::Value> value,

uint32_t flags) override;

void SetValueSilently(const std::string& key,

- scoped_ptr<base::Value> value,

+ std::unique_ptr<base::Value> value,

uint32_t flags) override;

void RemoveValue(const std::string& key, uint32_t flags) override;

bool ReadOnly() const override;