components/prefs/value_map_pref_store.h - Issue 1907043002: Convert //components/prefs from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/prefs/value_map_pref_store.h

Issue 1907043002: Convert //components/prefs from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IWYU fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/prefs/testing_pref_store.cc ('k') | components/prefs/value_map_pref_store.cc » ('j') | components/user_prefs/tracked/interceptable_pref_filter.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/prefs/value_map_pref_store.h

diff --git a/components/prefs/value_map_pref_store.h b/components/prefs/value_map_pref_store.h

index bddc64196b77845d8b01edbb7b0914f6951f9008..8310a9bad14bc668539f20798bfad8fc3e8a3e9a 100644

--- a/components/prefs/value_map_pref_store.h

+++ b/components/prefs/value_map_pref_store.h

@@ -31,13 +31,13 @@ class COMPONENTS_PREFS_EXPORT ValueMapPrefStore : public WriteablePrefStore {

// WriteablePrefStore overrides:

void SetValue(const std::string& key,

- scoped_ptr<base::Value> value,

+ std::unique_ptr<base::Value> value,

uint32_t flags) override;

void RemoveValue(const std::string& key, uint32_t flags) override;

bool GetMutableValue(const std::string& key, base::Value** value) override;

void ReportValueChanged(const std::string& key, uint32_t flags) override;

void SetValueSilently(const std::string& key,

- scoped_ptr<base::Value> value,

+ std::unique_ptr<base::Value> value,

uint32_t flags) override;

protected: