Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 190663012: Run ContentMain in a browser_test's browser process. This removes duplication of code in the browse… (Closed)

Created:
6 years, 9 months ago by jam
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, jshin+watch_chromium.org
Visibility:
Public.

Description

Run ContentMain in a browser_test's browser process. This removes duplication of code in the browser test harness for setting up the browser process, and also ensures that initialization code in ContentMainRunner runs. Most of the changes are to unit tests which run in browser test executables. These were getting all the setup that these binaries did for browser tests even though they were unit tests. Now they have to explicitly setup objects that they need. This would be done automatically if they were in a unit test binary and therefore using the unit test harness. The goal should be to move these tests to unit test binaries, and make them support launching some tests in separate processes building on the work that Pawel did. BUG=350550 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257597

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : content_browsertests passes #

Patch Set 4 : remove now unused flag #

Patch Set 5 : sync #

Patch Set 6 : get chrome unittests working #

Patch Set 7 : fix browser_tests, break unit_tests #

Patch Set 8 : fix unittests #

Patch Set 9 : fix extensions tests and android build #

Patch Set 10 : fix apitests #

Patch Set 11 : fix apps tests #

Patch Set 12 : more tests passing #

Patch Set 13 : more tests passing #

Patch Set 14 : fix nacl and webnavigation tests #

Patch Set 15 : fix single-process tests #

Patch Set 16 : fix more tests #

Patch Set 17 : fix content_unittests #

Patch Set 18 : sync to head #

Patch Set 19 : simpler approach of having InProcessBrowserTest override DIR_TEST_DATA early #

Patch Set 20 : simpler approach of having InProcessBrowserTest override DIR_TEST_DATA early #

Patch Set 21 : browser_tests all pass locally! #

Patch Set 22 : browser_tests all pass locally! #

Patch Set 23 : get interactive_ui_tests passing locally. also fix browser_tests that accidentally failed again #

Patch Set 24 : add isolate change, fix cros and linux failures #

Patch Set 25 : sync to head #

Patch Set 26 : try to fix mac #

Patch Set 27 : cleanup #

Patch Set 28 : cleanup #

Total comments: 20

Patch Set 29 : more cleanup and review comments #

Patch Set 30 : fix linux interactive_ui_tests #

Patch Set 31 : fix mac content_browsertests #

Patch Set 32 : fix mac browsertests #

Patch Set 33 : sync #

Patch Set 34 : fix mac browser_tests, bad merge in ash test, android compile fix, and remove new override of delet… #

Patch Set 35 : fix the couple of failing mac and cros browser_tests #

Patch Set 36 : try to fix android #

Patch Set 37 : sync. remove previous android attempt #

Patch Set 38 : try to fix android by restoring old path just for it #

Patch Set 39 : try to fix android by restoring old path just for it #

Patch Set 40 : try to fix android by restoring old path just for it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+759 lines, -695 lines) Patch
M ash/drag_drop/drag_drop_interactive_uitest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +24 lines, -1 line 0 comments Download
M ash/test/ash_test_base.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ash_test_base.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +12 lines, -0 lines 0 comments Download
M ash/wm/ash_native_cursor_manager_interactive_uitest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +25 lines, -1 line 0 comments Download
M base/i18n/icu_util.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +3 lines, -0 lines 0 comments Download
M base/i18n/icu_util.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +20 lines, -7 lines 0 comments Download
M chrome/browser/apps/web_view_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +31 lines, -36 lines 0 comments Download
M chrome/browser/chrome_browser_main_mac.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +13 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/login/login_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 5 chunks +7 lines, -74 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 5 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_apitest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/socket/socket_apitest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 4 chunks +11 lines, -80 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/extensions/app_background_page_apitest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/notifications/desktop_notifications_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/policy/policy_prefs_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 4 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +18 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 5 chunks +13 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +7 lines, -1 line 0 comments Download
M chrome/interactive_ui_tests.isolate View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 3 chunks +10 lines, -5 lines 0 comments Download
M chrome/renderer/extensions/dispatcher.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/renderer/media/cast_session_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +4 lines, -1 line 0 comments Download
M chrome/renderer/translate/translate_script_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/browser_perf_tests_main.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +1 line, -9 lines 0 comments Download
M chrome/test/base/browser_tests_main.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +1 line, -7 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 3 chunks +26 lines, -5 lines 0 comments Download
M chrome/test/base/chrome_test_launcher.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/test/base/chrome_test_suite.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 3 chunks +0 lines, -12 lines 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 6 chunks +5 lines, -128 lines 0 comments Download
M chrome/test/base/chrome_unit_test_suite.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +14 lines, -2 lines 0 comments Download
M chrome/test/base/chrome_unit_test_suite.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 3 chunks +127 lines, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 6 chunks +19 lines, -26 lines 0 comments Download
M chrome/test/base/interactive_ui_tests_main.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/base/view_event_test_base.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/base/view_event_test_base.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/test/nacl/nacl_browsertest_util.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/nacl/nacl_browsertest_util.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ppapi/ppapi_test.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/ppapi/ppapi_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 4 chunks +10 lines, -8 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/ui/ui_test_suite.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/ui/ui_test_suite.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +0 lines, -2 lines 0 comments Download
M content/app/content_main_runner.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 5 chunks +13 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +3 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +1 line, -1 line 0 comments Download
M content/public/app/content_main.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 3 chunks +11 lines, -6 lines 0 comments Download
M content/public/test/browser_test_base.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 5 chunks +14 lines, -5 lines 0 comments Download
M content/public/test/content_test_suite_base.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +7 lines, -9 lines 0 comments Download
M content/public/test/content_test_suite_base.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 4 chunks +13 lines, -20 lines 0 comments Download
M content/public/test/render_view_test.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 4 chunks +12 lines, -2 lines 0 comments Download
M content/public/test/render_view_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 3 chunks +22 lines, -6 lines 0 comments Download
M content/public/test/test_launcher.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +2 lines, -0 lines 0 comments Download
M content/public/test/test_launcher.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 4 chunks +26 lines, -39 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_browsertest.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 4 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 12 chunks +17 lines, -15 lines 0 comments Download
M content/renderer/browser_render_view_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 4 chunks +6 lines, -10 lines 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 3 chunks +3 lines, -5 lines 0 comments Download
M content/shell/renderer/shell_content_renderer_client.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/renderer/shell_content_renderer_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +0 lines, -11 lines 0 comments Download
M content/test/content_browser_test.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 2 chunks +6 lines, -6 lines 0 comments Download
M content/test/content_browser_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 6 chunks +18 lines, -26 lines 0 comments Download
M content/test/content_test_launcher.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 2 chunks +25 lines, -47 lines 0 comments Download
M content/test/content_test_suite.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/content_test_suite.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 4 chunks +9 lines, -5 lines 0 comments Download
M ui/views/corewm/desktop_capture_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +20 lines, -1 line 0 comments Download
M ui/views/test/ui_controls_factory_desktop_aurax11.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 12 chunks +39 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
Scott: I now have green try runs on Windows and mostly green on Linux. So ...
6 years, 9 months ago (2014-03-14 20:33:46 UTC) #1
sky
https://codereview.chromium.org/190663012/diff/460001/ash/drag_drop/drag_drop_interactive_uitest.cc File ash/drag_drop/drag_drop_interactive_uitest.cc (right): https://codereview.chromium.org/190663012/diff/460001/ash/drag_drop/drag_drop_interactive_uitest.cc#newcode128 ash/drag_drop/drag_drop_interactive_uitest.cc:128: gfx::GLSurface::InitializeOneOffForTests(); Is there a reason you don't want to ...
6 years, 9 months ago (2014-03-14 21:35:55 UTC) #2
jam
https://codereview.chromium.org/190663012/diff/460001/ash/drag_drop/drag_drop_interactive_uitest.cc File ash/drag_drop/drag_drop_interactive_uitest.cc (right): https://codereview.chromium.org/190663012/diff/460001/ash/drag_drop/drag_drop_interactive_uitest.cc#newcode128 ash/drag_drop/drag_drop_interactive_uitest.cc:128: gfx::GLSurface::InitializeOneOffForTests(); On 2014/03/14 21:35:56, sky wrote: > Is there ...
6 years, 9 months ago (2014-03-14 22:35:40 UTC) #3
sky
6 years, 9 months ago (2014-03-14 23:04:23 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698