Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: chrome/test/base/chrome_test_suite.h

Issue 190663012: Run ContentMain in a browser_test's browser process. This removes duplication of code in the browse… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: try to fix android by restoring old path just for it Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/chrome_test_launcher.cc ('k') | chrome/test/base/chrome_test_suite.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/chrome_test_suite.h
===================================================================
--- chrome/test/base/chrome_test_suite.h (revision 257432)
+++ chrome/test/base/chrome_test_suite.h (working copy)
@@ -11,10 +11,6 @@
#include "base/memory/scoped_ptr.h"
#include "content/public/test/content_test_suite_base.h"
-namespace base {
-class StatsTable;
-}
-
// Test suite for unit and browser tests. Creates services needed by both.
// See also ChromeUnitTestSuite for additional services created for unit tests.
class ChromeTestSuite : public content::ContentTestSuiteBase {
@@ -27,12 +23,6 @@
virtual void Initialize() OVERRIDE;
virtual void Shutdown() OVERRIDE;
- virtual content::ContentClient* CreateClientForInitialization() OVERRIDE;
-
- // Should return true if the test suite will be running the full chrome
- // browser, false if the test suite is unit tests.
- virtual bool IsBrowserTestSuite() = 0;
-
void SetBrowserDirectory(const base::FilePath& browser_dir) {
browser_dir_ = browser_dir;
}
@@ -40,8 +30,6 @@
// Alternative path to browser binaries.
base::FilePath browser_dir_;
- std::string stats_filename_;
- scoped_ptr<base::StatsTable> stats_table_;
DISALLOW_COPY_AND_ASSIGN(ChromeTestSuite);
};
« no previous file with comments | « chrome/test/base/chrome_test_launcher.cc ('k') | chrome/test/base/chrome_test_suite.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698