Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1299)

Unified Diff: content/test/content_browser_test.h

Issue 190663012: Run ContentMain in a browser_test's browser process. This removes duplication of code in the browse… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: try to fix android by restoring old path just for it Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/renderer/shell_content_renderer_client.cc ('k') | content/test/content_browser_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/content_browser_test.h
===================================================================
--- content/test/content_browser_test.h (revision 257432)
+++ content/test/content_browser_test.h (working copy)
@@ -28,10 +28,6 @@
// BrowserTestBase:
virtual void RunTestOnMainThreadLoop() OVERRIDE;
- // Must be called before or during setup.
- void SetContentRendererClient(
- scoped_ptr<ContentRendererClient> renderer_client);
-
protected:
// Creates a new window and loads about:blank.
Shell* CreateBrowser();
@@ -43,14 +39,18 @@
Shell* shell() const { return shell_; }
private:
- scoped_ptr<ShellMainDelegate> shell_main_delegate_;
-
Shell* shell_;
bool setup_called_;
+#if defined(OS_ANDROID)
+ // For all other platforms, this is done automatically when calling into
+ // ContentMain. For Android we set things up manually.
+ scoped_ptr<ShellMainDelegate> shell_main_delegate_;
+
// ContentRendererClient when running in single-process mode.
scoped_ptr<ContentRendererClient> single_process_renderer_client_;
+#endif
};
} // namespace content
« no previous file with comments | « content/shell/renderer/shell_content_renderer_client.cc ('k') | content/test/content_browser_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698