Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1906493002: headless: Replace headless::Maybe with base::Optional (Closed)

Created:
4 years, 8 months ago by Sami
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Replace headless::Maybe with base::Optional Covered by existing tests. BUG=595353, 604860 Committed: https://crrev.com/b2232e6103ff4c902452d9468f543637e091f95b Cr-Commit-Position: refs/heads/master@{#388495}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -186 lines) Patch
M headless/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M headless/lib/browser/types_cc.template View 2 chunks +3 lines, -3 lines 0 comments Download
M headless/lib/browser/types_h.template View 3 chunks +5 lines, -5 lines 0 comments Download
D headless/public/util/maybe.h View 1 chunk +0 lines, -93 lines 0 comments Download
D headless/public/util/maybe_unittest.cc View 1 chunk +0 lines, -83 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Sami
4 years, 8 months ago (2016-04-20 12:06:00 UTC) #3
mlamouri (slow - plz ping)
lgtm
4 years, 8 months ago (2016-04-20 13:00:02 UTC) #4
mlamouri (slow - plz ping)
Maybe you can add BUG=604860 ?
4 years, 8 months ago (2016-04-20 13:00:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906493002/1
4 years, 8 months ago (2016-04-20 13:47:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 14:40:19 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:23:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2232e6103ff4c902452d9468f543637e091f95b
Cr-Commit-Position: refs/heads/master@{#388495}

Powered by Google App Engine
This is Rietveld 408576698