Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: headless/lib/browser/types_h.template

Issue 1906493002: headless: Replace headless::Maybe with base::Optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/lib/browser/types_cc.template ('k') | headless/public/util/maybe.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/lib/browser/types_h.template
diff --git a/headless/lib/browser/types_h.template b/headless/lib/browser/types_h.template
index 79c89e0d9f876297080058f10ab19435b5e8623e..0d883ea9446d49283d38a31ad4e1a994c207af62 100644
--- a/headless/lib/browser/types_h.template
+++ b/headless/lib/browser/types_h.template
@@ -7,10 +7,10 @@
#ifndef HEADLESS_PUBLIC_DOMAINS_TYPES_H_
#define HEADLESS_PUBLIC_DOMAINS_TYPES_H_
+#include "base/optional.h"
#include "base/values.h"
#include "headless/public/headless_export.h"
#include "headless/public/util/error_reporter.h"
-#include "headless/public/util/maybe.h"
#include "base/memory/ptr_util.h"
@@ -69,9 +69,9 @@ class HEADLESS_EXPORT {{type.id}} {
// {{property.description}}
{% endif %}
{% if property.optional %}
- bool Has{{property.name | to_title_case}}() { return {{property.name | camelcase_to_hacker_style}}_.IsJust(); }
- {{resolve_type(property).raw_return_type}} Get{{property.name | to_title_case}}() { return {{resolve_type(property).to_raw_return_type % ("%s_.FromJust()" % property.name | camelcase_to_hacker_style)}}; }
- void Set{{property.name | to_title_case}}({{resolve_type(property).pass_type}} value) { {{property.name | camelcase_to_hacker_style}}_ = Just({{resolve_type(property).to_pass_type % 'value'}}); }
+ bool Has{{property.name | to_title_case}}() { return !!{{property.name | camelcase_to_hacker_style}}_; }
+ {{resolve_type(property).raw_return_type}} Get{{property.name | to_title_case}}() { return {{resolve_type(property).to_raw_return_type % ("%s_.value()" % property.name | camelcase_to_hacker_style)}}; }
+ void Set{{property.name | to_title_case}}({{resolve_type(property).pass_type}} value) { {{property.name | camelcase_to_hacker_style}}_ = {{resolve_type(property).to_pass_type % 'value'}}; }
{% else %}
{{resolve_type(property).raw_return_type}} Get{{property.name | to_title_case}}() { return {{resolve_type(property).to_raw_return_type % ("%s_" % property.name | camelcase_to_hacker_style)}}; }
void Set{{property.name | to_title_case}}({{resolve_type(property).pass_type}} value) { {{property.name | camelcase_to_hacker_style}}_ = {{resolve_type(property).to_pass_type % 'value'}}; }
@@ -139,7 +139,7 @@ class HEADLESS_EXPORT {{type.id}} {
{% for property in type.properties %}
{% if property.optional %}
- Maybe<{{resolve_type(property).type}}> {{property.name | camelcase_to_hacker_style}}_;
+ base::Optional<{{resolve_type(property).type}}> {{property.name | camelcase_to_hacker_style}}_;
{% else %}
{{resolve_type(property).type}} {{property.name | camelcase_to_hacker_style}}_;
{% endif %}
« no previous file with comments | « headless/lib/browser/types_cc.template ('k') | headless/public/util/maybe.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698