Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: headless/lib/browser/types_cc.template

Issue 1906493002: headless: Replace headless::Maybe with base::Optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/BUILD.gn ('k') | headless/lib/browser/types_h.template » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/lib/browser/types_cc.template
diff --git a/headless/lib/browser/types_cc.template b/headless/lib/browser/types_cc.template
index 1c2d6b81462b47bfa1334ecc5ad25040fbe9a50c..5be72cf79240a5f5be27e902a802b040a4ada3ff 100644
--- a/headless/lib/browser/types_cc.template
+++ b/headless/lib/browser/types_cc.template
@@ -83,7 +83,7 @@ std::unique_ptr<{{type.id}}> {{type.id}}::Parse(const base::Value& value, ErrorR
if (object->Get("{{property.name}}", &{{value_name}})) {
errors->SetName("{{property.name}}");
{% if property.optional %}
- result->{{property.name | camelcase_to_hacker_style}}_ = Just(internal::FromValue<{{resolve_type(property).raw_type}}>::Parse(*{{value_name}}, errors));
+ result->{{property.name | camelcase_to_hacker_style}}_ = internal::FromValue<{{resolve_type(property).raw_type}}>::Parse(*{{value_name}}, errors);
{% else %}
result->{{property.name | camelcase_to_hacker_style}}_ = internal::FromValue<{{resolve_type(property).raw_type}}>::Parse(*{{value_name}}, errors);
{% endif %}
@@ -107,8 +107,8 @@ std::unique_ptr<base::Value> {{type.id}}::Serialize() const {
{% for property in type.properties %}
{% set type = resolve_type(property) %}
{% if property.optional %}
- if ({{property.name | camelcase_to_hacker_style}}_.IsJust())
- result->Set("{{property.name}}", internal::ToValue({{type.to_raw_type % ("%s_.FromJust()" % property.name | camelcase_to_hacker_style)}}));
+ if ({{property.name | camelcase_to_hacker_style}}_)
+ result->Set("{{property.name}}", internal::ToValue({{type.to_raw_type % ("%s_.value()" % property.name | camelcase_to_hacker_style)}}));
{% else %}
result->Set("{{property.name}}", internal::ToValue({{type.to_raw_type % ("%s_" % property.name | camelcase_to_hacker_style)}}));
{% endif %}
« no previous file with comments | « headless/BUILD.gn ('k') | headless/lib/browser/types_h.template » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698