Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1906453002: Revert of Change calling convention of CallApiGetterStub to accept the AccessorInfo (Closed)

Created:
4 years, 8 months ago by Michael Hablich
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Change calling convention of CallApiGetterStub to accept the AccessorInfo (patchset #8 id:140001 of https://codereview.chromium.org/1892533004/ ) Reason for revert: Blocks roll: https://codereview.chromium.org/1896103002/ Can also be seen on internal waterfall: https://chromegw.corp.google.com/i/internal.client.v8/builders/v8_cros_perf_1/builds/7558 Original issue's description: > Change calling convention of CallApiGetterStub to accept the AccessorInfo > > MIPS port contributed by Balazs Kilvady <balazs.kilvady@imgtec.com>; > > Committed: https://crrev.com/d2b0a4b727f77f97960c7fa71da3431591dc959f > Cr-Commit-Position: refs/heads/master@{#35606} TBR=rodolph.perfetta@arm.com,jkummerow@chromium.org,jacob.bramley@arm.com,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/12d727a86e1732c2347a1af1086f49b33bcbd5b3 Cr-Commit-Position: refs/heads/master@{#35644}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+435 lines, -310 lines) Patch
M src/accessors.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/api.cc View 3 chunks +1 line, -8 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 2 chunks +10 lines, -34 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +9 lines, -33 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/external-reference-table.cc View 1 chunk +4 lines, -14 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +16 lines, -39 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +51 lines, -0 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +52 lines, -0 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +60 lines, -0 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +60 lines, -0 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +52 lines, -0 lines 0 comments Download
M src/interface-descriptors.h View 1 chunk +4 lines, -5 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +13 lines, -7 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +10 lines, -34 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 2 chunks +10 lines, -34 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/objects.h View 2 chunks +3 lines, -18 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-printer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +12 lines, -34 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Hablich
Created Revert of Change calling convention of CallApiGetterStub to accept the AccessorInfo
4 years, 8 months ago (2016-04-20 07:23:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906453002/1
4 years, 8 months ago (2016-04-20 07:23:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 07:23:41 UTC) #4
Michael Hablich
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1903093003/ by hablich@chromium.org. ...
4 years, 8 months ago (2016-04-20 08:00:44 UTC) #5
nodir1
4 years, 8 months ago (2016-04-22 18:43:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12d727a86e1732c2347a1af1086f49b33bcbd5b3
Cr-Commit-Position: refs/heads/master@{#35644}

Powered by Google App Engine
This is Rietveld 408576698