Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: src/external-reference-table.cc

Issue 1906453002: Revert of Change calling convention of CallApiGetterStub to accept the AccessorInfo (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm64/interface-descriptors-arm64.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/external-reference-table.h" 5 #include "src/external-reference-table.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/assembler.h" 8 #include "src/assembler.h"
9 #include "src/counters.h" 9 #include "src/counters.h"
10 #include "src/deoptimizer.h" 10 #include "src/deoptimizer.h"
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 Add(isolate->get_address_from_id(static_cast<Isolate::AddressId>(i)), 290 Add(isolate->get_address_from_id(static_cast<Isolate::AddressId>(i)),
291 address_names[i]); 291 address_names[i]);
292 } 292 }
293 293
294 // Accessors 294 // Accessors
295 struct AccessorRefTable { 295 struct AccessorRefTable {
296 Address address; 296 Address address;
297 const char* name; 297 const char* name;
298 }; 298 };
299 299
300 static const AccessorRefTable getters[] = { 300 static const AccessorRefTable accessors[] = {
301 #define ACCESSOR_INFO_DECLARATION(name) \ 301 #define ACCESSOR_INFO_DECLARATION(name) \
302 {FUNCTION_ADDR(&Accessors::name##Getter), "Accessors::" #name "Getter"}, 302 {FUNCTION_ADDR(&Accessors::name##Getter), "Accessors::" #name "Getter"},
303 ACCESSOR_INFO_LIST(ACCESSOR_INFO_DECLARATION) 303 ACCESSOR_INFO_LIST(ACCESSOR_INFO_DECLARATION)
304 #undef ACCESSOR_INFO_DECLARATION 304 #undef ACCESSOR_INFO_DECLARATION
305 };
306 static const AccessorRefTable setters[] = {
307 #define ACCESSOR_SETTER_DECLARATION(name) \ 305 #define ACCESSOR_SETTER_DECLARATION(name) \
308 {FUNCTION_ADDR(&Accessors::name), "Accessors::" #name}, 306 {FUNCTION_ADDR(&Accessors::name), "Accessors::" #name},
309 ACCESSOR_SETTER_LIST(ACCESSOR_SETTER_DECLARATION) 307 ACCESSOR_SETTER_LIST(ACCESSOR_SETTER_DECLARATION)
310 #undef ACCESSOR_INFO_DECLARATION 308 #undef ACCESSOR_INFO_DECLARATION
311 }; 309 };
312 310
313 for (unsigned i = 0; i < arraysize(getters); ++i) { 311 for (unsigned i = 0; i < arraysize(accessors); ++i) {
314 Add(getters[i].address, getters[i].name); 312 Add(accessors[i].address, accessors[i].name);
315 #ifdef USE_SIMULATOR
316 Add(AccessorInfo::redirect(isolate, getters[i].address, ACCESSOR_GETTER),
317 getters[i].name);
318 #endif
319 }
320
321 for (unsigned i = 0; i < arraysize(setters); ++i) {
322 Add(setters[i].address, setters[i].name);
323 } 313 }
324 314
325 StubCache* stub_cache = isolate->stub_cache(); 315 StubCache* stub_cache = isolate->stub_cache();
326 316
327 // Stub cache tables 317 // Stub cache tables
328 Add(stub_cache->key_reference(StubCache::kPrimary).address(), 318 Add(stub_cache->key_reference(StubCache::kPrimary).address(),
329 "StubCache::primary_->key"); 319 "StubCache::primary_->key");
330 Add(stub_cache->value_reference(StubCache::kPrimary).address(), 320 Add(stub_cache->value_reference(StubCache::kPrimary).address(),
331 "StubCache::primary_->value"); 321 "StubCache::primary_->value");
332 Add(stub_cache->map_reference(StubCache::kPrimary).address(), 322 Add(stub_cache->map_reference(StubCache::kPrimary).address(),
(...skipping 24 matching lines...) Expand all
357 for (int entry = 0; entry < kDeoptTableSerializeEntryCount; ++entry) { 347 for (int entry = 0; entry < kDeoptTableSerializeEntryCount; ++entry) {
358 Address address = Deoptimizer::GetDeoptimizationEntry( 348 Address address = Deoptimizer::GetDeoptimizationEntry(
359 isolate, entry, Deoptimizer::LAZY, 349 isolate, entry, Deoptimizer::LAZY,
360 Deoptimizer::CALCULATE_ENTRY_ADDRESS); 350 Deoptimizer::CALCULATE_ENTRY_ADDRESS);
361 Add(address, "lazy_deopt"); 351 Add(address, "lazy_deopt");
362 } 352 }
363 } 353 }
364 354
365 } // namespace internal 355 } // namespace internal
366 } // namespace v8 356 } // namespace v8
OLDNEW
« no previous file with comments | « src/arm64/interface-descriptors-arm64.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698