Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Side by Side Diff: src/accessors.cc

Issue 1906453002: Revert of Change calling convention of CallApiGetterStub to accept the AccessorInfo (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/accessors.h" 5 #include "src/accessors.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/contexts.h" 8 #include "src/contexts.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/execution.h" 10 #include "src/execution.h"
(...skipping 21 matching lines...) Expand all
32 info->set_all_can_read(false); 32 info->set_all_can_read(false);
33 info->set_all_can_write(false); 33 info->set_all_can_write(false);
34 info->set_is_special_data_property(true); 34 info->set_is_special_data_property(true);
35 name = factory->InternalizeName(name); 35 name = factory->InternalizeName(name);
36 info->set_name(*name); 36 info->set_name(*name);
37 Handle<Object> get = v8::FromCData(isolate, getter); 37 Handle<Object> get = v8::FromCData(isolate, getter);
38 if (setter == nullptr) setter = &ReconfigureToDataProperty; 38 if (setter == nullptr) setter = &ReconfigureToDataProperty;
39 Handle<Object> set = v8::FromCData(isolate, setter); 39 Handle<Object> set = v8::FromCData(isolate, setter);
40 info->set_getter(*get); 40 info->set_getter(*get);
41 info->set_setter(*set); 41 info->set_setter(*set);
42 #ifdef USE_SIMULATOR
43 Address redirected = info->redirected_getter();
44 if (redirected != nullptr) {
45 Handle<Object> js_get = v8::FromCData(isolate, redirected);
46 info->set_js_getter(*js_get);
47 }
48 #endif
49 return info; 42 return info;
50 } 43 }
51 44
52 45
53 static V8_INLINE bool CheckForName(Handle<Name> name, 46 static V8_INLINE bool CheckForName(Handle<Name> name,
54 Handle<String> property_name, 47 Handle<String> property_name,
55 int offset, 48 int offset,
56 int* object_offset) { 49 int* object_offset) {
57 if (Name::Equals(name, property_name)) { 50 if (Name::Equals(name, property_name)) {
58 *object_offset = offset; 51 *object_offset = offset;
(...skipping 1199 matching lines...) Expand 10 before | Expand all | Expand 10 after
1258 Isolate* isolate = name->GetIsolate(); 1251 Isolate* isolate = name->GetIsolate();
1259 Handle<AccessorInfo> info = MakeAccessor(isolate, name, &ModuleGetExport, 1252 Handle<AccessorInfo> info = MakeAccessor(isolate, name, &ModuleGetExport,
1260 &ModuleSetExport, attributes); 1253 &ModuleSetExport, attributes);
1261 info->set_data(Smi::FromInt(index)); 1254 info->set_data(Smi::FromInt(index));
1262 return info; 1255 return info;
1263 } 1256 }
1264 1257
1265 1258
1266 } // namespace internal 1259 } // namespace internal
1267 } // namespace v8 1260 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698