Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1915443003: Replace scoped_ptr with std::unique_ptr in //media. (Closed)

Created:
4 years, 8 months ago by danakj
Modified:
4 years, 8 months ago
Reviewers:
brettw, DaleCurtis, dcheng
CC:
chromium-reviews, dcheng, eme-reviews_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, piman, posciak+watch_chromium.org, toyoshim+midi_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@scopedptr-media-base
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace scoped_ptr with std::unique_ptr in //media. R=brettw, dalecurtis, dcheng BUG=554298 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/4d43bc26cc5d105edb1e976582803ea931e572e1 Cr-Commit-Position: refs/heads/master@{#389684}

Patch Set 1 #

Patch Set 2 : scopedptr-media: . #

Patch Set 3 : scopedptr-media: . #

Patch Set 4 : scopedptr-media: . #

Patch Set 5 : scopedptr-media: rebase #

Patch Set 6 : scopedptr-media: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+460 lines, -404 lines) Patch
M media/blink/run_all_unittests.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M media/cdm/aes_decryptor.h View 5 chunks +9 lines, -9 lines 0 comments Download
M media/cdm/aes_decryptor.cc View 11 chunks +13 lines, -12 lines 0 comments Download
M media/cdm/aes_decryptor_unittest.cc View 5 chunks +15 lines, -18 lines 0 comments Download
M media/cdm/cdm_adapter.h View 8 chunks +14 lines, -14 lines 0 comments Download
M media/cdm/cdm_adapter.cc View 14 chunks +17 lines, -15 lines 0 comments Download
M media/cdm/cdm_adapter_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M media/cdm/cdm_allocator.h View 2 chunks +3 lines, -2 lines 0 comments Download
M media/cdm/cenc_utils.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M media/cdm/json_web_key.cc View 10 chunks +15 lines, -12 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/cdm_video_decoder.h View 2 chunks +5 lines, -3 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/cdm_video_decoder.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.h View 2 chunks +4 lines, -4 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 7 chunks +31 lines, -30 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/ffmpeg_cdm_audio_decoder.h View 3 chunks +4 lines, -4 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/ffmpeg_cdm_video_decoder.h View 2 chunks +4 lines, -3 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/libvpx_cdm_video_decoder.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M media/cdm/simple_cdm_allocator.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M media/cdm/simple_cdm_allocator.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/cdm/simple_cdm_allocator_unittest.cc View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
M media/ffmpeg/ffmpeg_common.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M media/ffmpeg/ffmpeg_common_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M media/midi/midi_manager_alsa.h View 12 chunks +16 lines, -15 lines 0 comments Download
M media/midi/midi_manager_alsa.cc View 14 chunks +36 lines, -27 lines 0 comments Download
M media/midi/midi_manager_alsa_unittest.cc View 1 2 2 chunks +26 lines, -22 lines 0 comments Download
M media/midi/midi_manager_android.h View 3 chunks +4 lines, -3 lines 0 comments Download
M media/midi/midi_manager_android.cc View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M media/midi/midi_manager_mac_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M media/midi/midi_manager_unittest.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M media/midi/midi_manager_usb.h View 5 chunks +7 lines, -6 lines 0 comments Download
M media/midi/midi_manager_usb.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/midi/midi_manager_usb_unittest.cc View 1 2 10 chunks +16 lines, -13 lines 0 comments Download
M media/midi/midi_manager_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/midi/midi_manager_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/midi/usb_midi_device.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/midi/usb_midi_device_android.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M media/midi/usb_midi_device_factory_android.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M media/midi/usb_midi_input_stream_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/midi/usb_midi_output_stream_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/muxers/webm_muxer.h View 5 chunks +8 lines, -8 lines 0 comments Download
M media/muxers/webm_muxer.cc View 6 chunks +9 lines, -7 lines 0 comments Download
M media/muxers/webm_muxer_unittest.cc View 1 2 7 chunks +10 lines, -9 lines 0 comments Download
M media/renderers/audio_renderer_impl.h View 6 chunks +7 lines, -7 lines 0 comments Download
M media/renderers/audio_renderer_impl_unittest.cc View 1 2 5 chunks +5 lines, -4 lines 0 comments Download
M media/renderers/gpu_video_accelerator_factories.h View 4 chunks +9 lines, -6 lines 0 comments Download
M media/renderers/mock_gpu_video_accelerator_factories.h View 4 chunks +9 lines, -6 lines 0 comments Download
M media/renderers/mock_gpu_video_accelerator_factories.cc View 1 2 4 chunks +10 lines, -10 lines 0 comments Download
M media/renderers/renderer_impl.h View 3 chunks +6 lines, -6 lines 0 comments Download
M media/renderers/renderer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/renderers/renderer_impl_unittest.cc View 1 2 4 chunks +10 lines, -9 lines 0 comments Download
M media/renderers/video_renderer_impl.h View 1 2 3 4 5 4 chunks +7 lines, -7 lines 0 comments Download
M media/renderers/video_renderer_impl.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M media/renderers/video_renderer_impl_unittest.cc View 1 2 3 4 5 5 chunks +6 lines, -4 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 7 chunks +22 lines, -17 lines 0 comments Download
M media/test/pipeline_integration_test_base.h View 1 2 4 chunks +9 lines, -8 lines 0 comments Download
M media/test/pipeline_integration_test_base.cc View 11 chunks +11 lines, -10 lines 0 comments Download
M media/video/gpu_memory_buffer_video_frame_pool.cc View 1 2 5 chunks +5 lines, -4 lines 0 comments Download
M media/video/gpu_memory_buffer_video_frame_pool_unittest.cc View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M media/video/video_decode_accelerator.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M media/video/video_encode_accelerator.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
danakj
4 years, 8 months ago (2016-04-23 01:06:46 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915443003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915443003/40001
4 years, 8 months ago (2016-04-23 01:13:36 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/159580) mac_chromium_compile_dbg_ng on ...
4 years, 8 months ago (2016-04-23 01:34:25 UTC) #5
DaleCurtis
Spot checked a fair number of instances, lgtm
4 years, 8 months ago (2016-04-23 19:02:05 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 1906423005 Patch 80001). Please resolve the dependency and ...
4 years, 8 months ago (2016-04-25 20:34:19 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915443003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915443003/60001
4 years, 8 months ago (2016-04-25 20:36:24 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/56385)
4 years, 8 months ago (2016-04-25 21:13:47 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915443003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915443003/80001
4 years, 8 months ago (2016-04-25 22:30:16 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn/builds/24778) ios_rel_device_ninja on ...
4 years, 8 months ago (2016-04-25 22:34:31 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915443003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915443003/100001
4 years, 8 months ago (2016-04-26 01:30:34 UTC) #22
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 8 months ago (2016-04-26 03:36:17 UTC) #23
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 03:37:15 UTC) #25
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/4d43bc26cc5d105edb1e976582803ea931e572e1
Cr-Commit-Position: refs/heads/master@{#389684}

Powered by Google App Engine
This is Rietveld 408576698