 Chromium Code Reviews
 Chromium Code Reviews Issue 1906423005:
  Replace scoped_ptr with std::unique_ptr in //media/base.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1906423005:
  Replace scoped_ptr with std::unique_ptr in //media/base.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW | 
|---|---|
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be | 
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. | 
| 4 | 4 | 
| 5 #ifndef MEDIA_BASE_TEXT_TRACK_H_ | 5 #ifndef MEDIA_BASE_TEXT_TRACK_H_ | 
| 6 #define MEDIA_BASE_TEXT_TRACK_H_ | 6 #define MEDIA_BASE_TEXT_TRACK_H_ | 
| 7 | 7 | 
| 8 #include <memory> | |
| 8 #include <string> | 9 #include <string> | 
| 9 | 10 | 
| 10 #include "base/callback.h" | 11 #include "base/callback.h" | 
| 11 #include "base/memory/scoped_ptr.h" | |
| 12 #include "base/time/time.h" | 12 #include "base/time/time.h" | 
| 13 | 13 | 
| 14 namespace media { | 14 namespace media { | 
| 15 | 15 | 
| 16 class TextTrackConfig; | 16 class TextTrackConfig; | 
| 17 | 17 | 
| 18 class TextTrack { | 18 class TextTrack { | 
| 19 public: | 19 public: | 
| 20 virtual ~TextTrack() {} | 20 virtual ~TextTrack() {} | 
| 21 virtual void addWebVTTCue(const base::TimeDelta& start, | 21 virtual void addWebVTTCue(const base::TimeDelta& start, | 
| 22 const base::TimeDelta& end, | 22 const base::TimeDelta& end, | 
| 23 const std::string& id, | 23 const std::string& id, | 
| 24 const std::string& content, | 24 const std::string& content, | 
| 25 const std::string& settings) = 0; | 25 const std::string& settings) = 0; | 
| 26 }; | 26 }; | 
| 27 | 27 | 
| 28 typedef base::Callback<void | 28 typedef base::Callback<void(std::unique_ptr<TextTrack>)> AddTextTrackDoneCB; | 
| 
dcheng
2016/04/23 00:57:23
using, possibly
 
danakj
2016/04/23 01:11:15
Done.
 | |
| 29 (scoped_ptr<TextTrack>)> AddTextTrackDoneCB; | |
| 30 | 29 | 
| 31 typedef base::Callback<void | 30 typedef base::Callback<void | 
| 32 (const TextTrackConfig& config, | 31 (const TextTrackConfig& config, | 
| 33 const AddTextTrackDoneCB& done_cb)> AddTextTrackCB; | 32 const AddTextTrackDoneCB& done_cb)> AddTextTrackCB; | 
| 34 | 33 | 
| 35 } // namespace media | 34 } // namespace media | 
| 36 | 35 | 
| 37 #endif // MEDIA_BASE_TEXT_TRACK_H_ | 36 #endif // MEDIA_BASE_TEXT_TRACK_H_ | 
| OLD | NEW |