Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1906403002: Revert of Make Response::body return v8-extra based stream behind flag (Closed)

Created:
4 years, 8 months ago by kjellander_chromium
Modified:
4 years, 8 months ago
Reviewers:
tyoshino (SeeGerritForStatus), Yuki, blink-reviews-bindings, horo, haraken, yhirano
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, blink-reviews-bindings_chromium.org, falken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@notify-locked-released
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make Response::body return v8-extra based stream behind flag (patchset #5 id:160001 of https://codereview.chromium.org/1899873006/ ) Reason for revert: Several tests reports leaks after this: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/18984 Original issue's description: > Make Response::body return v8-extra based stream behind flag > > This CL makes Response::body return a v8-extra based ReadableStream when > ResponseBodyWithV8ExtraStream is enabled. > > This CL also deprecates Response.v8ExtraStreamBody(). > > BUG=596832 TBR=tyoshino@chromium.org,blink-reviews-bindings@chromium.org,yukishiino@chromium.org,haraken@chromium.org,horo@chromium.org,yhirano@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=596832 Committed: https://crrev.com/1e847c4832de7e730af916e9f8901eeb54c0df76 Cr-Commit-Position: refs/heads/master@{#389081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+497 lines, -372 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/v8-extra-body.js View 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker/v8-extra-body.html View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker/v8-extra-body-base-https-other-https.html View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/fetch/window/v8-extra-body.html View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/fetch/window/v8-extra-body-base-https-other-https.html View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/fetch/workers/v8-extra-body.html View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/fetch/workers/v8-extra-body-base-https-other-https.html View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/streams/UnderlyingSourceBase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/Cache.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Body.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Body.cpp View 7 chunks +78 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.h View 3 chunks +14 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp View 8 chunks +44 lines, -148 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp View 18 chunks +45 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchManager.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchRequestData.h View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchRequestData.cpp View 4 chunks +9 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchResponseData.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp View 5 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Request.h View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Request.cpp View 5 chunks +33 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Request.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/RequestTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.cpp View 10 chunks +27 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.idl View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/ResponseTest.cpp View 9 chunks +31 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
kjellander_chromium
Created Revert of Make Response::body return v8-extra based stream behind flag
4 years, 8 months ago (2016-04-22 12:15:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906403002/1
4 years, 8 months ago (2016-04-22 12:16:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 12:16:58 UTC) #4
Yuki
lgtm
4 years, 8 months ago (2016-04-22 12:17:20 UTC) #5
haraken
LGTM to revert
4 years, 8 months ago (2016-04-22 18:02:34 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:46:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e847c4832de7e730af916e9f8901eeb54c0df76
Cr-Commit-Position: refs/heads/master@{#389081}

Powered by Google App Engine
This is Rietveld 408576698