third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp - Issue 1906403002: Revert of Make Response::body return v8-extra based stream behind flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

Issue 1906403002: Revert of Make Response::body return v8-extra based stream behind flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@notify-locked-released

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/ResponseTest.cpp ('k') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

index 28b433d6e34f4d09d9f947e0c22726d97a96dc77..0b2dc8977f3c8fd717b512b4f87541d9e7587ecb 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

@@ -242,13 +242,13 @@

response->populateWebServiceWorkerResponse(webResponse);

BodyStreamBuffer* buffer = response->internalBodyBuffer();

if (buffer) {

- RefPtr<BlobDataHandle> blobDataHandle = buffer->drainAsBlobDataHandle(FetchDataConsumerHandle::Reader::AllowBlobWithInvalidSize);

+ RefPtr<BlobDataHandle> blobDataHandle = buffer->drainAsBlobDataHandle(getExecutionContext(), FetchDataConsumerHandle::Reader::AllowBlobWithInvalidSize);

if (blobDataHandle) {

webResponse.setBlobDataHandle(blobDataHandle);

} else {

Stream* outStream = Stream::create(getExecutionContext(), "");

webResponse.setStreamURL(outStream->url());

- buffer->startLoading(FetchDataLoader::createLoaderAsStream(outStream), new NoopLoaderClient);

+ buffer->startLoading(getExecutionContext(), FetchDataLoader::createLoaderAsStream(outStream), new NoopLoaderClient);

}

ServiceWorkerGlobalScopeClient::from(getExecutionContext())->didHandleFetchEvent(m_eventID, webResponse);