third_party/WebKit/Source/modules/fetch/FetchManager.cpp - Issue 1906403002: Revert of Make Response::body return v8-extra based stream behind flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

Issue 1906403002: Revert of Make Response::body return v8-extra based stream behind flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@notify-locked-released

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp ('k') | third_party/WebKit/Source/modules/fetch/FetchRequestData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

index e740f2637cfd5fee1ce8b03d74ae95c85f77ee4b..d50b1634affc1fceffba90581d1c7e28ea620e1b 100644

--- a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

+++ b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

@@ -291,13 +291,12 @@

}

- ScriptState* scriptState = m_resolver->getScriptState();

FetchResponseData* responseData = nullptr;

CompositeDataConsumerHandle::Updater* updater = nullptr;

if (m_request->integrity().isEmpty())

- responseData = FetchResponseData::createWithBuffer(new BodyStreamBuffer(scriptState, createFetchDataConsumerHandleFromWebHandle(handle)));

+ responseData = FetchResponseData::createWithBuffer(new BodyStreamBuffer(createFetchDataConsumerHandleFromWebHandle(handle)));

else

- responseData = FetchResponseData::createWithBuffer(new BodyStreamBuffer(scriptState, createFetchDataConsumerHandleFromWebHandle(CompositeDataConsumerHandle::create(createWaitingDataConsumerHandle(), &updater))));

+ responseData = FetchResponseData::createWithBuffer(new BodyStreamBuffer(createFetchDataConsumerHandleFromWebHandle(CompositeDataConsumerHandle::create(createWaitingDataConsumerHandle(), &updater))));

responseData->setStatus(response.httpStatusCode());

responseData->setStatusMessage(response.httpStatusText());

for (auto& it : response.httpHeaderFields())

@@ -567,7 +566,7 @@

if (m_request->method() != HTTPNames::GET && m_request->method() != HTTPNames::HEAD) {

if (m_request->buffer())

- request.setHTTPBody(m_request->buffer()->drainAsFormData());

+ request.setHTTPBody(m_request->buffer()->drainAsFormData(m_executionContext));

if (m_request->attachedCredential())

request.setAttachedCredential(m_request->attachedCredential());

}