Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1906373002: Revert of [GN] Define USE_EABI_HARDFLOAT=1 when arm_float_abi=="hard". (Closed)

Created:
4 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke, alokp, slan, titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [GN] Define USE_EABI_HARDFLOAT=1 when arm_float_abi=="hard". (patchset #1 id:1 of https://codereview.chromium.org/1839763003/ ) Reason for revert: Appears to break Android crbug.com/604422 Original issue's description: > [GN] Define USE_EABI_HARDFLOAT=1 when arm_float_abi=="hard". > > Add this define to the config used for mksnapshot. This fixes a bug > where certain applications would fail at runtime on Chromecast. > > BUG=592660 > LOG=Y > Bug: internal b/27495984 > > Test: Formerly broken Cast apps load and run as expected. > > Committed: https://crrev.com/86357d5235ceba61c151f0b6e509bcb365860454 > Cr-Commit-Position: refs/heads/master@{#35183} TBR=dpranke@chromium.org,alokp@chromium.org,titzer@chromium.org,slan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=592660, 604422 LOG=n Committed: https://crrev.com/0714485cbb4ea72359ae9ec73f9fb6c825a933e1 Cr-Commit-Position: refs/heads/master@{#35725}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M BUILD.gn View 4 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
jochen (gone - plz use gerrit)
Created Revert of [GN] Define USE_EABI_HARDFLOAT=1 when arm_float_abi=="hard".
4 years, 8 months ago (2016-04-22 10:54:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906373002/1
4 years, 8 months ago (2016-04-22 10:54:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906373002/1
4 years, 8 months ago (2016-04-22 10:54:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14040)
4 years, 8 months ago (2016-04-22 10:58:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906373002/1
4 years, 8 months ago (2016-04-22 11:01:45 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 11:19:18 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:15:29 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0714485cbb4ea72359ae9ec73f9fb6c825a933e1
Cr-Commit-Position: refs/heads/master@{#35725}

Powered by Google App Engine
This is Rietveld 408576698