Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: BUILD.gn

Issue 1906373002: Revert of [GN] Define USE_EABI_HARDFLOAT=1 when arm_float_abi=="hard". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 8b5e35d6471a87d2b08a98116d9e502ce3930658..dbc02959db14cb330691c15771f6e07b8a6f33b2 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -143,6 +143,7 @@
cflags = []
# TODO(jochen): Add support for arm subarchs, mips, mipsel, mips64el.
+
if (v8_target_arch == "arm") {
defines += [ "V8_TARGET_ARCH_ARM" ]
if (current_cpu == "arm") {
@@ -169,13 +170,8 @@
"CAN_USE_ARMV7_INSTRUCTIONS",
"CAN_USE_VFP3_INSTRUCTIONS",
"CAN_USE_VFP32DREGS",
+ "USE_EABI_HARDFLOAT=0",
]
-
- if (arm_float_abi == "hard") {
- defines += [ "USE_EABI_HARDFLOAT=1" ]
- } else if (arm_float_abi == "softfp") {
- defines += [ "USE_EABI_HARDFLOAT=0" ]
- }
}
# TODO(jochen): Add support for arm_test_noprobe.
@@ -191,7 +187,7 @@
}
if (v8_target_arch == "s390") {
defines += [ "V8_TARGET_ARCH_S390" ]
- }
+ }
if (v8_target_arch == "s390x") {
defines += [
"V8_TARGET_ARCH_S390",
@@ -204,7 +200,7 @@
if (v8_target_arch == "x64") {
defines += [ "V8_TARGET_ARCH_X64" ]
}
-
+
if (is_win) {
defines += [ "WIN32" ]
# TODO(jochen): Support v8_enable_prof.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698