Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1906353002: Revert of V8: Show build environment in failure logs (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of V8: Show build environment in failure logs (patchset #5 id:80001 of https://codereview.chromium.org/1901103004/ ) Reason for revert: Might break the CQ: http://crbug.com/605846 Original issue's description: > V8: Show build environment in failure logs > > This will make it easier for developers to reproduce > failures. > > Currently, the indirection between builders/testers and > between swarming trigger/collect makes it hard to > reason how the test executables were built. > > BUG=605516 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300080 TBR=kjellander@chromium.org,tandrii@chromium.org BUG=605516, 605846 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300106

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1939 lines) Patch
M scripts/slave/recipe_modules/v8/api.py View 3 chunks +0 lines, -34 lines 0 comments Download
M scripts/slave/recipe_modules/v8/test_api.py View 1 chunk +1 line, -5 lines 0 comments Download
M scripts/slave/recipes/v8.py View 1 chunk +0 lines, -10 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN.json View 5 chunks +0 lines, -20 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json View 3 chunks +0 lines, -12 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___custom_snapshot___debug_builder.json View 2 chunks +0 lines, -8 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___custom_snapshot___debug_slim_bisect_tester_swarming.json View 2 chunks +0 lines, -10 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug___greedy_allocator_bisect_tester.json View 2 chunks +0 lines, -10 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json View 4 chunks +0 lines, -16 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_one_failure.json View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures.json View 19 chunks +0 lines, -76 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_flakes.json View 2 chunks +0 lines, -8 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_bisect_tester_swarming.json View 2 chunks +0 lines, -10 lines 0 comments Download
D scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_one_failure_build_env_not_supported.json View 1 chunk +0 lines, -1371 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder.json View 4 chunks +0 lines, -16 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___debug_builder.json View 4 chunks +0 lines, -16 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_builder.json View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_debug_builder.json View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect.json View 4 chunks +0 lines, -16 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_one_change.json View 2 chunks +0 lines, -8 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_override_changes.json View 4 chunks +0 lines, -16 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_recurring_failure.json View 4 chunks +0 lines, -16 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_tests_too_long.json View 2 chunks +0 lines, -8 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___shared_bisect_swarming.json View 4 chunks +0 lines, -16 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___builder.json View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug_builder.json View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Android_Arm64___builder.json View 1 chunk +0 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Android_Arm___builder.json View 1 chunk +0 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Arm___builder.json View 2 chunks +0 lines, -14 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Arm___debug_builder.json View 2 chunks +0 lines, -14 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mipsel___sim___builder.json View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___x87___nosnap___debug_builder.json View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___builder.json View 2 chunks +0 lines, -18 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_asan_rel_ng.json View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_rel_ng.json View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_rel_ng.json View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_rel_ng.json View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_dbg_ng.json View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nodcheck_rel_ng.json View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng.json View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_triggered_failures.json View 19 chunks +0 lines, -95 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_triggered_flakes.json View 2 chunks +0 lines, -10 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_rel_ng.json View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng.json View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_nosnap_shared_rel_ng.json View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_rel_ng.json View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Achenbach
Created Revert of V8: Show build environment in failure logs
4 years, 8 months ago (2016-04-22 07:20:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906353002/1
4 years, 8 months ago (2016-04-22 07:21:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300106
4 years, 8 months ago (2016-04-22 07:25:44 UTC) #7
tandrii(chromium)
4 years, 8 months ago (2016-04-22 10:33:28 UTC) #8
Message was sent while issue was closed.
eh, lgtm

Powered by Google App Engine
This is Rietveld 408576698