scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug_builder.json - Issue 1906353002: Revert of V8: Show build environment in failure logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug_builder.json

Issue 1906353002: Revert of V8: Show build environment in failure logs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___builder.json ('k') | scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Android_Arm64___builder.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug_builder.json

diff --git a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug_builder.json b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug_builder.json

index df2c158f689c0d6189035626e29b7c449eaa7865..49dd687ce512bd0b47e65a6f51cc63130db8eab5 100644

--- a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug_builder.json

+++ b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug_builder.json

@@ -232,10 +232,6 @@

{

"builder_name": "V8 Win32 - debug",

"properties": {

- "build_environment": {

- "GYP_DEFINES": "chromium_win_pch=0 fastbuild=1 target_arch=ia32 test_isolation_mode=prepare use_goma=1 v8_enable_slow_dchecks=1 v8_optimized_debug=1 v8_target_arch=ia32",

- "GYP_GENERATORS": "ninja"

- },

"parent_got_revision": "f2cbea7e89a45f46819777bb78a1f5bd0241f64c",

"parent_got_revision_cp": "refs/heads/master@{#50110}",

"parent_got_swarming_client_revision": "e4fee0b18f8163be6097c9c571640038896debc4",