Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: scripts/slave/recipe_modules/v8/api.py

Issue 1906353002: Revert of V8: Show build environment in failure logs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/v8/test_api.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/v8/api.py
diff --git a/scripts/slave/recipe_modules/v8/api.py b/scripts/slave/recipe_modules/v8/api.py
index 2758c42e7ab14df2dca11c1c80841a0e588d8a18..0b1ef83a7fa4a5523e547efe561e23f1aa144f3d 100644
--- a/scripts/slave/recipe_modules/v8/api.py
+++ b/scripts/slave/recipe_modules/v8/api.py
@@ -264,25 +264,6 @@
env['GYP_MSVS_VERSION'] = self.m.chromium.c.gyp_env.GYP_MSVS_VERSION
self.m.chromium.runhooks(env=env, **kwargs)
- @property
- def build_environment(self):
- if self.m.properties.get('build_environment'):
- return self.m.properties['build_environment']
- if self.bot_type == 'tester':
- return None
- build_environment = dict(
- (k, v) for (k, v) in self.m.chromium.c.gyp_env.as_jsonish().iteritems()
- if k.startswith('GYP') and v is not None
- )
- build_environment.update(self.c.gyp_env.as_jsonish())
- if 'GYP_DEFINES' in build_environment:
- # Filter out gomadir.
- build_environment['GYP_DEFINES'] = ' '.join(
- d for d in build_environment['GYP_DEFINES'].split()
- if not d.startswith('gomadir')
- )
- return build_environment
-
def setup_mips_toolchain(self):
mips_dir = self.m.path['slave_build'].join(MIPS_DIR, 'bin')
if not self.m.path.exists(mips_dir):
@@ -713,15 +694,6 @@
lines.append('Test: %s%s' % (results[0]['name'], flaky_suffix))
lines.append('Flags: %s' % ' '.join(results[0]['flags']))
lines.append('Command: %s' % results[0]['command'])
- lines.append('')
- lines.append('Build environment:')
- build_environment = self.build_environment
- if build_environment is None:
- lines.append(
- 'Not available. Please look up the builder\'s configuration.')
- else:
- for key in sorted(build_environment):
- lines.append(' %s: %s' % (key, build_environment[key]))
lines.append('')
# Add results for each run of a command.
@@ -973,12 +945,6 @@
# TODO(machenbach): Also set meaningful buildbucket tags of triggering
# parent.
- # Pass build environment to testers if it doesn't exceed buildbot's
- # limits.
- # TODO(machenbach): Remove the check in the after-buildbot age.
- if len(self.m.json.dumps(self.build_environment)) < 1024:
- properties['build_environment'] = self.build_environment
-
swarm_hashes = self.m.isolate.isolated_tests
if swarm_hashes:
properties['swarm_hashes'] = swarm_hashes
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/v8/test_api.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698