Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1906293002: [Findit] Adding additional fields to try job metadata (Closed)

Created:
4 years, 8 months ago by lijeffrey
Modified:
4 years, 8 months ago
Reviewers:
chanli, stgao
CC:
chromium-reviews, infra-reviews+infra_chromium.org, Sharu Jiang
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Adding additional fields to try job metadata BUG=605363 Committed: https://chromium.googlesource.com/infra/infra/+/fb4a38fd292f43d4c7e3b70fdaf039b2b45cdd4c

Patch Set 1 #

Patch Set 2 : Fixing comment #

Total comments: 5

Patch Set 3 : Fixing extraneous field in BuildBucketBuild #

Patch Set 4 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -34 lines) Patch
M appengine/findit/common/waterfall/buildbucket_client.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M appengine/findit/model/wf_try_job_data.py View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/monitor_try_job_pipeline.py View 4 chunks +42 lines, -27 lines 0 comments Download
M appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
lijeffrey
This change consolidates the method for updating try job metadata and adds build number for ...
4 years, 8 months ago (2016-04-22 00:15:31 UTC) #3
stgao
https://codereview.chromium.org/1906293002/diff/20001/appengine/findit/common/waterfall/buildbucket_client.py File appengine/findit/common/waterfall/buildbucket_client.py (right): https://codereview.chromium.org/1906293002/diff/20001/appengine/findit/common/waterfall/buildbucket_client.py#newcode87 appengine/findit/common/waterfall/buildbucket_client.py:87: self.buildbucket_response = raw_json_data Why we save two copies of ...
4 years, 8 months ago (2016-04-22 00:37:53 UTC) #4
lijeffrey
https://codereview.chromium.org/1906293002/diff/20001/appengine/findit/common/waterfall/buildbucket_client.py File appengine/findit/common/waterfall/buildbucket_client.py (right): https://codereview.chromium.org/1906293002/diff/20001/appengine/findit/common/waterfall/buildbucket_client.py#newcode87 appengine/findit/common/waterfall/buildbucket_client.py:87: self.buildbucket_response = raw_json_data On 2016/04/22 00:37:53, stgao wrote: > ...
4 years, 8 months ago (2016-04-22 00:50:53 UTC) #5
stgao
https://codereview.chromium.org/1906293002/diff/20001/appengine/findit/model/wf_try_job_data.py File appengine/findit/model/wf_try_job_data.py (right): https://codereview.chromium.org/1906293002/diff/20001/appengine/findit/model/wf_try_job_data.py#newcode35 appengine/findit/model/wf_try_job_data.py:35: last_buildbucket_response = ndb.JsonProperty(indexed=False) On 2016/04/22 00:50:53, lijeffrey wrote: > ...
4 years, 8 months ago (2016-04-22 01:06:22 UTC) #6
lijeffrey
On 2016/04/22 01:06:22, stgao wrote: > https://codereview.chromium.org/1906293002/diff/20001/appengine/findit/model/wf_try_job_data.py > File appengine/findit/model/wf_try_job_data.py (right): > > https://codereview.chromium.org/1906293002/diff/20001/appengine/findit/model/wf_try_job_data.py#newcode35 > ...
4 years, 8 months ago (2016-04-22 01:14:41 UTC) #7
lijeffrey
4 years, 8 months ago (2016-04-22 01:15:23 UTC) #8
chanli
On 2016/04/22 01:15:23, lijeffrey wrote: lgtm.
4 years, 8 months ago (2016-04-22 02:09:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906293002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906293002/60001
4 years, 8 months ago (2016-04-22 18:17:59 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 18:22:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/infra/infra/+/fb4a38fd292f43d4c7e3b70fdaf03...

Powered by Google App Engine
This is Rietveld 408576698