[Findit] Adding additional fields to try job metadata

appengine/findit/common/waterfall/buildbucket_client.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """"Serves as a client for selected APIs in Buildbucket."""
 
 import collections
 import json
 import logging
 
@@ skipping 59 matching lines @@
 
   This corresponds to the Build in Buildbucket.
   """
 
   # Build statuses.
   SCHEDULED = 'SCHEDULED'
   STARTED = 'STARTED'
   COMPLETED = 'COMPLETED'
 
   def __init__(self, raw_json_data):
+    self.response = raw_json_data
     self.id = raw_json_data.get('id')
     self.url = raw_json_data.get('url')
     self.status = raw_json_data.get('status')
     self.request_time = raw_json_data.get('created_ts')
     self.updated_time = raw_json_data.get('updated_ts')
     self.end_time = raw_json_data.get('completed_ts')
+    self.buildbucket_response = raw_json_data

[stgao, 2016/04/22 00:37:53]

Why we save two copies of the same data?

[lijeffrey, 2016/04/22 00:50:53]

Oops, removed.

     result_details_json = json.loads(
         raw_json_data.get('result_details_json', '{}')) or {}
     self.report = result_details_json.get('properties', {}).get('report', {})
 
 
 class BuildbucketError(object):
   """Represents an error returned by Buildbucket."""
 
   # Error reasons.
   BUILD_NOT_FOUND = 'BUILD_NOT_FOUND'
@@ skipping 87 matching lines @@
     else:
       error_content = {
           'error': {
               'reason': status_code,
               'message': content
           }
       }
       json_results.append(error_content)
 
   return _ConvertFuturesToResults(json_results)