Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2437)

Unified Diff: appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py

Issue 1906293002: [Findit] Adding additional fields to try job metadata (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Addressing comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/waterfall/monitor_try_job_pipeline.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py
diff --git a/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py b/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py
index 81508cad36bfb4897c03d58bb71fe6855687bed5..7441c555920404d724f026593023d62d300c3a4d 100644
--- a/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py
+++ b/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py
@@ -138,8 +138,8 @@ class MonitorTryJobPipelineTest(wf_testcase.WaterfallTestCase):
error = buildbucket_client.BuildbucketError(error_data)
try_job_data = WfTryJobData.Create('1')
- MonitorTryJobPipeline._UpdateTryJobMetadataForBuildError(
- try_job_data, error)
+ MonitorTryJobPipeline._UpdateTryJobMetadata(
+ try_job_data, None, None, error, False)
self.assertEqual(try_job_data.error, error_data)
def testUpdateTryJobMetadataForCompletedBuild(self):
@@ -168,8 +168,8 @@ class MonitorTryJobPipelineTest(wf_testcase.WaterfallTestCase):
build = buildbucket_client.BuildbucketBuild(build_data)
try_job_data = WfTryJobData.Create(try_job_id)
- MonitorTryJobPipeline._UpdateTryJobMetadataForCompletedBuild(
- try_job_data, build, None, timed_out=False)
+ MonitorTryJobPipeline._UpdateTryJobMetadata(
+ try_job_data, None, build, None, False)
try_job_data = WfTryJobData.Get(try_job_id)
self.assertIsNone(try_job_data.error)
self.assertEqual(try_job_data.regression_range_size, 2)
@@ -179,10 +179,10 @@ class MonitorTryJobPipelineTest(wf_testcase.WaterfallTestCase):
datetime(2016, 2, 1, 22, 59, 30))
self.assertEqual(try_job_data.try_job_url, url)
- MonitorTryJobPipeline._UpdateTryJobMetadataForCompletedBuild(
- try_job_data, build, None, timed_out=True)
+ MonitorTryJobPipeline._UpdateTryJobMetadata(
+ try_job_data, None, build, None, True)
self.assertEqual(try_job_data.error,
- {'message': MonitorTryJobPipeline.TIMEOUT,
+ {'message': 'Try job monitoring was abandoned.',
'reason': MonitorTryJobPipeline.TIMEOUT})
def testGetTryJobsForCompileSuccess(self):
« no previous file with comments | « appengine/findit/waterfall/monitor_try_job_pipeline.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698