Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1905553002: Expose toString() as enumerable on some objects. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, Jens Widell, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@sof-tidy-idl-pars
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose toString() as enumerable on some objects. URL, WorkerLocation and implementations of HTMLHyperlinkElementUtils are required per spec to expose an enumerable toString() method. Remove uses of [NotEnumerable] for these. R=philipj@opera.com, jochen BUG=306606 Committed: https://crrev.com/ca9d83f416cb0fc53e886c2bf308a167d3d12758 Cr-Commit-Position: refs/heads/master@{#388521}

Patch Set 1 #

Patch Set 2 : test coverage for overall URL offerings #

Patch Set 3 : sync expected outputs #

Patch Set 4 : one more expectation updated #

Patch Set 5 : rebased #

Messages

Total messages: 16 (8 generated)
sof
please take a look. Time to align with spec and others, see associated bug and ...
4 years, 8 months ago (2016-04-20 09:47:30 UTC) #3
philipj_slow
The argument in https://www.w3.org/Bugs/Public/show_bug.cgi?id=26179 was for consistency with ES builtins. I don't about all of ...
4 years, 8 months ago (2016-04-20 10:04:44 UTC) #4
philipj_slow
LGTM, but it is a web-exposed change and the opposite direction was once suggested, so ...
4 years, 8 months ago (2016-04-20 10:07:33 UTC) #6
sof
On 2016/04/20 10:04:44, philipj_slow wrote: > The argument in https://www.w3.org/Bugs/Public/show_bug.cgi?id=26179 was for > consistency with ...
4 years, 8 months ago (2016-04-20 10:55:02 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-20 12:48:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905553002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905553002/80001
4 years, 8 months ago (2016-04-20 15:53:36 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-20 16:47:47 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:24:24 UTC) #16
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/ca9d83f416cb0fc53e886c2bf308a167d3d12758
Cr-Commit-Position: refs/heads/master@{#388521}

Powered by Google App Engine
This is Rietveld 408576698